If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

nsMessengerWinIntegration.h compile error C2365: QUNS_NOT_PRESENT

RESOLVED FIXED in Thunderbird 54.0

Status

MailNews Core
Build Config
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: frg, Assigned: frg)

Tracking

Trunk
Thunderbird 54.0
Unspecified
Windows

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

8 months ago
+++ This bug was initially created as a clone of Bug #1334464 +++

d:\seamonkey\comm-central\mailnews\base\src\nsMessengerWinIntegration.h(24): error C2365: 'QUNS_NOT_PRESENT': redefinition; previous
 definition was 'enumerator'
C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\um\shellapi.h(980): note: see declaration of 'QUNS_NOT_PRESENT'
d:\seamonkey\comm-central\mailnews\base\src\nsMessengerWinIntegration.h(25): error C2365: 'QUNS_BUSY': redefinition; previous defini
tion was 'enumerator'
(Assignee)

Comment 1

8 months ago
Takes a little longer.

I am crashing because of this one: 

https://hg.mozilla.org/mozilla-central/rev/5a6fc9e02f9d

Comment 2

8 months ago
That's another bug, or do you want to port two bugs here? Can we land your patch for the Windows integration? It compiled OK for me. Do we know which bug regressed this to note that in the commit message?
(Assignee)

Updated

8 months ago
Depends on: 1325299
(Assignee)

Comment 3

8 months ago
Created attachment 8831171 [details] [diff] [review]
1334489-SHQueryUserNotificationState.patch

This patch removes the enums but doesn't call SHQueryUserNotificationState directly.
(Assignee)

Comment 4

8 months ago
Created attachment 8831179 [details] [diff] [review]
1334489-SHQueryUserNotificationState-part2.patch

Could you check this one out. SeaMonkey 2.51 currently crashes during startup.
Attachment #8831179 - Flags: feedback?(jorgk)
(Assignee)

Comment 5

8 months ago
Comment on attachment 8831171 [details] [diff] [review]
1334489-SHQueryUserNotificationState.patch

This could go in. The other would be just icing on top.
Attachment #8831171 - Flags: review?(jorgk)

Comment 6

8 months ago
Well, I'd like to understand first why we're here. What's changed so QUNS_NOT_PRESENT and friend are now defined twice. Something is now including nsAlertsService.h when it didn't before?

Comment 7

8 months ago
I get it now: Bug 1325299. They've changed the WINVER and that triggers this
#if (NTDDI_VERSION >= NTDDI_VISTA)
typedef enum
{
    QUNS_NOT_PRESENT               = 1,    
in shellapi.h.

OK, I'll do the review now.

Comment 8

8 months ago
Created attachment 8831214 [details] [diff] [review]
1334489-SHQueryUserNotificationState.patch (v2).

I took the liberty to merge the two patches. Part 2 removed some of the stuff that part 1 had corrected, so I think it's best to rip it all out in one go ;-)

Like my Spanish plumber always says: "Fuera!" (meaning: Out!).
Attachment #8831171 - Attachment is obsolete: true
Attachment #8831179 - Attachment is obsolete: true
Attachment #8831171 - Flags: review?(jorgk)
Attachment #8831179 - Flags: feedback?(jorgk)
Attachment #8831214 - Flags: review+

Comment 9

8 months ago
https://hg.mozilla.org/comm-central/rev/aa9ec692549119aac1abf473af2056adb97ad7cb

Windows will now compile again.

At least debug builds will crash on bug 1276669 with lovely stuff as can be seen in bug 1334558.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 54.0
You need to log in before you can comment on or make changes to this bug.