|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
I was going to do some work on testing/web-platform related to BUG_COMPONENT, but I found an error: elvis@JMAHER-WIN10 ~/mozilla-inbound $ ./mach file-info bugzilla-component testing/web-platform Error running mach: ['file-info', 'bugzilla-component', 'testing/web-platform'] The error occurred in code that was called by the mach command. This is either a bug in the called code itself or in the way that mach is calling it. You should consider filing a bug for this issue. If filing a bug, please include the full output of mach, including this error message. The details of the failure are as follows: ValueError: too many values to unpack File "c:\Users\elvis\mozilla-inbound\python/mozbuild/mozbuild/frontend/mach_commands.py", line 108, in file_info_bugzilla for p, m in self._get_files_info(paths, rev=rev).items(): File "c:\Users\elvis\mozilla-inbound\python/mozbuild/mozbuild/frontend/mach_commands.py", line 218, in _get_files_info return reader.files_info(allpaths) File "c:\Users\elvis\mozilla-inbound\python/mozbuild\mozbuild\frontend\reader.py", line 1394, in files_info flags += self.test_defaults_for_path(ctxs) File "c:\Users\elvis\mozilla-inbound\python/mozbuild\mozbuild\frontend\reader.py", line 1418, in test_defaults_for_path for t in (mozpath.join(tests_root, path) for path, _ in obj): File "c:\Users\elvis\mozilla-inbound\python/mozbuild\mozbuild\frontend\reader.py", line 1418, in <genexpr> for t in (mozpath.join(tests_root, path) for path, _ in obj): if I remove the definition for WEB_PLATFORM_TEST_MANIFESTS: https://hg.mozilla.org/mozilla-central/annotate/1e0e193b0812f68a12fbd69198552af62347af1e/testing/web-platform/moz.build#l7 things work as expected. This worked 2 weeks ago and testing/web-platform/moz.build didn't have any changes to this section of the code in a long time. I suspect something in mach broke.
I'm hitting this as well.
Any suggestions on trying to figure this out?
This is a build system bug. Looks like WEB_PLATFORM_TEST_MANIFESTS behaves slightly differently from other test manifest variables. Should be an easy fix.
Regressed in the following changeset: changeset: 370160:beb43155b7a6 user: James Graham <email@example.com> date: Fri Jan 06 12:52:28 2017 +0000 summary: Bug 1331899 - Fix wpt manifest iterator to return the test path, r=Ms2ger diff --git a/testing/web-platform/tests/tools/manifest/manifest.py b/testing/web-platform/tests/tools/manifest/manifest. --- a/testing/web-platform/tests/tools/manifest/manifest.py +++ b/testing/web-platform/tests/tools/manifest/manifest.py @@ -44,7 +44,7 @@ class Manifest(object): types = sorted(self._data.keys()) for item_type in types: for path, tests in sorted(iteritems(self._data[item_type])): - yield item_type, tests + yield item_type, path, tests @property def reftest_nodes_by_url(self):
<3 thanks gps!
Comment on attachment 8857687 [details] Bug 1334525 - Handle tuple types and WPT manifests correctly; https://reviewboard.mozilla.org/r/129622/#review132732
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/6370e9cae248 Handle tuple types and WPT manifests correctly; r=chmanchester