Closed
Bug 1334527
Opened 9 years ago
Closed 9 years ago
Can't select some datapoints in graph when > 1 job per push
Categories
(Tree Management :: Perfherder, defect)
Tree Management
Perfherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: wlach)
Details
Attachments
(1 file)
Example: https://treeherder.mozilla.org/perf.html#/graphs?series=%5Bmozilla-aurora,7601f68563dc6dad10bc630a38bb80e7b78fe5b1,1,2%5D
Our problem seems to be that we're indexing by resultset, not job when trying to figure out the point to highlight.
I could swear this was working properly at some point, so I'm not sure how it broke. At least this is easy to fix...
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Updated•9 years ago
|
Attachment #8831181 -
Flags: review?(jmaher)
|
|
Assignee | |
Comment 2•9 years ago
|
||
More just asking for a rubber stamp here than a comprehensive review.
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8831181 [details] [review]
[treeherder] wlach:1334527 > mozilla:master
way into the rubber stamp territory
Attachment #8831181 -
Flags: review?(jmaher) → review+
|
||
Comment 4•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/e331ce77f94690079020fee1094338e47712f2e3
Bug 1334527 - Fix data selection in perfherder graphs when > 1 job per push (#2113)
|
|
Assignee | |
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•