110.16 KB, text/plain
17.92 KB, image/gif
2.68 KB, patch
Alexandru Savulov: review+
Marc Attinasi: superreview+
|Details | Diff | Splinter Review|
Created attachment 76170 [details] Screenshot of error message from eBay This is the error eBay returns.
likely dup of bug 132673. Any advanced use of WMP and Shockwave were also broken. Fixed 03/26/2002 03:15.
Confirming, 2002032610, Windows 2000. Exactly as reported described.
Not related to bug 132673. This was a problem a while before that bug appeared, and still continues with today's build (2002032708).
This is a regression that occured between 02-12-2002 and 02-18-2002. Marc Attinasi can confirm this, we tested with his account. Vladimire: please see if this can be narrowed down to a day or lower so that we can find the check in that caused the regression. I will work on this too. Thanx!
new time window for the regression: 2-16-2002 and 2-18-2002
we think it was caused by the patch for bug 120682
nsbeta1+, topembed+. [adt1]. Can not upload picture of for sale item on EBAY.
Created attachment 77576 [details] [diff] [review] patch preview this is what happened: we stopped attachng the file name if there is no file or the name is invalid. here are 2 snapshots of the raw HTTP trafic: before fix for bug 120682: ... -----------------------------157241916926500 Content-Disposition: form-data; name="file2"; filename="" Content-Type: application/octet-stream -----------------------------157241916926500 Content-Disposition: form-data; name="file3"; filename="" Content-Type: application/octet-stream ... after the fix: ... -----------------------------265001916915724 Content-Disposition: form-data; name="file2" -----------------------------265001916915724 Content-Disposition: form-data; name="file3" ... now i think that we have to keep doing what we did before. i tested the ebay page and it works. John: please take a look at the patch and let me know what parts to remove and how do you prefer to restructure the nsHTMLInputElement::SubmitNamesValues method, the parts that are afected after the call rv = file->InitWithUnicodePath(value.get()); there are parts that might be removed. before i do anything further i need your oppinion please.
Created attachment 77607 [details] [diff] [review] Patch v1.1 OK, I just went through and added a few things, we may as well go all the way and do what IE does, submit filename and Content-Type *always* for file inputs, even if there is no file. Some programs apparently expect this behavior and die horribly if it's not there. Sigh. This patch also fixes bug 132069, which I will shortly dup to this bug.
*** Bug 132069 has been marked as a duplicate of this bug. ***
Comment on attachment 77607 [details] [diff] [review] Patch v1.1 r= alexsavulov some how i agree with me :-)
BTW, I used that patch to upload the patch, and also tested the behavior when entering: (a) an empty filename; (b) an invalidly formed filename (C:\\blah.txt is invalid on Linux for example) (c) a valid filename that does not exist (/usr/local/blahblahblah.blah for example) (a) sends filename="" and shows content-type=application/octet-stream, as does IE. (b) sends filename="C:\\blah.txt" (in that case) and shows application/octet-stream, as does IE. (c) sends filename="blahblahblah.blah" because that what it would have sent if the file did exist (for security reasons, don't tell the server the user's directory), and application/octet-stream.
Comment on attachment 77607 [details] [diff] [review] Patch v1.1 sr=attinasi
Comment on attachment 77607 [details] [diff] [review] Patch v1.1 a=asa (on behalf of drivers) for checkin to the 1.0 trunk
added adt100 after checking with kevin mccluskey
Have we tested on all platforms, and other types of Form Submission on other sites? If yes, and it looks great, adt1.0.0+ (on ADT's behalf) approval for checkin into 1.0.
tested on windows, linux, mac patch in fixed on the 1.0 trunk WHASUP eBAY DUDES... BE COOL... USE OUR BROWSER! ;-)
*** Bug 136339 has been marked as a duplicate of this bug. ***
verifying on build 2002-04-10-03-trunk windows 98, no more error messages
*** Bug 131845 has been marked as a duplicate of this bug. ***
*** Bug 133774 has been marked as a duplicate of this bug. ***
Verifying on 07/17 branch on windows 98