Closed
Bug 1334556
Opened 7 years ago
Closed 7 years ago
make GitRepository.get_modified_files slightly more idiomatic
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox54 fixed)
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
1.38 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
Having to munge the output of `git status --porcelain` is unseemly when there are approaches that will give us what we want directly.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8831219 -
Flags: review?(gps)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8831219 [details] [diff] [review] make GitRepository.get_modified_files slightly more idiomatic Review of attachment 8831219 [details] [diff] [review]: ----------------------------------------------------------------- Nice.
Attachment #8831219 -
Flags: review?(gps) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c8c13fab0df2 make GitRepository.get_modified_files slightly more idiomatic; r=gps
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c8c13fab0df2
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•