Closed Bug 1334566 Opened 3 years ago Closed 3 years ago

Autophone - rca tests start but fail to complete on Beta and Release

Categories

(Testing :: Autophone, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bc, Assigned: bc)

References

Details

Attachments

(1 file)

The actual issue was due to the upload directory containing directories which caused s3 to raise an uncaught IOError when it tried to read the directory as a file. This prevented the upload from completing and left the job in a running state.

I introduced find_files(path) into utils.py which uses os.path.walk to find all files contained in the upload directory.

I also added the ability to save a copy of the log file on the local disk if the log level is set to DEBUG. This helped find the issue which was otherwise lost.

I'm r=self on this patch since I want to get it in production and stop the rca tests from failing due to this.
Attachment #8831429 - Flags: review+
https://github.com/mozilla/autophone/commit/80a79c4e93dd37a3a17dc4e9370e1b7d4d2d37e9
deployed 2017-01-28 05:00
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Comment on attachment 8831429 [details] [diff] [review]
bug-1334566-upload.patch

jmaher: If you want to review this after the fact and have me make any changes, I would be happy to do so.
Attachment #8831429 - Flags: feedback?(jmaher)
Comment on attachment 8831429 [details] [diff] [review]
bug-1334566-upload.patch

Review of attachment 8831429 [details] [diff] [review]:
-----------------------------------------------------------------

moar utility functions
Attachment #8831429 - Flags: feedback?(jmaher) → feedback+
You need to log in before you can comment on or make changes to this bug.