1334659 - [autoconfig] Advanced config: Canceling the advanced account creation dialog creates the new account

Status: VERIFIED WORKSFORME

(Thunderbird :: Account Manager, defect)

Description

[Nomis101]

I found this while testing TB 52beta, but it is still present in trunk. If you cancel the "Advanced config", TB creates a new account, but should just close the dialog.

Steps to reproduce:
- In a new TB profile do the following:
- Create a new email account and choose "Skip this and use my existing email".
- Type in name, address and password and click "Continue".
- Regardless if ISP autoconfig worked or not, choose "Manual config".
- Than choose "Advanced config".
- Cancel the opened dialog.

Actual result:
A new email account will be created with the settings from ISP autoconfig.

Expected:
I would expect "Cancel" only closes the "Advanced config", so you can continue in "Manual config". Same like "Cancel" only close the "Manual config" dialog.

Comment 1

[:aceman]

I think this is quite complicated as we need an account object already created before entering the account manager for the "advanced config" feature.

We could destroy this object when leaving with "cancel" clicked, but the account could already have created stuff on disk. So we would need to simulate all the account removal tasks (as if Remove account was clicked), or just call that removal dialog but do not let the user interfere with it.
It would still leave some remnants of the account (like increased mail.account.lastKey pref value).

Are we sure semantically the user really wants to cancel the account creation when at this late step?

Comment 2

[Nomis101]

(In reply to :aceman from comment #1)
> Are we sure semantically the user really wants to cancel the account
> creation when at this late step?

No, not the account creation, just close this "Advanced config" window, so you are back in "Manual config" and you can continue from there. If a user is clicking on "Cancel" he wants to cancel something and expect this is happening. If the user wants to create an account he will click "OK".

Comment 3

[:aceman]

To open the account manager window, the server type had to be fixed in the account (POP3, IMAP, etc.). Coming back to the manual config we would have to disable the type picking widgets and maybe others. Also the account wizard surely expects the account is not yet created.

Comment 4

[Richard Marti (:Paenglab)]

I think the "Advanced config" is misleading as this isn't needed to create a new account and it's position looks more like there are advanced options for the connectivity to the servers. But it is used for account fine tuning after creation.

The button should be moved aside of the "Create" button or maybe better after clicking "Create" a dialog should ask if the user wants to go to the Advanced settings.

Comment 5

[Wayne Mery (:wsmwk)]

Is this still an issue with version 91?

Comment 6

[Nomis101]

Seems you are digging out all my old bugs. :-D This still happens, but bevor the new account is created a warning does appear. So, it is not an issue anymore.

Comment 7

[Ben Bucksch (:BenB)]

That's great! Thanks for confirming this.