Open
Bug 1334661
Opened 9 years ago
Updated 5 years ago
Remove constructors (static initializers) from Linux sandboxing code
Categories
(Core :: Security: Process Sandboxing, defect, P5)
Tracking
()
NEW
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | affected |
People
(Reporter: jld, Unassigned)
Details
(Whiteboard: sb+)
Right now there are two constructor functions that I know of in the Linux sandboxing code, and they don't really need to be there:
* in glue/SandboxCrash.cpp, to poke the address of SandboxCrash (in libxul) into a variable in libmozsandbox. This could be done later, immediately before sandboxing is started (e.g., at the top of SetCurrentProcessSandbox).
* The SandboxInfo singleton, which could be changed to be lazily constructed the first time it's requested. There *was* a rationale for doing it that way, but it no longer applies now that the sandboxing code has been moved out of plugin-container. However, the calls to getenv should be changed to PR_GetEnv (adding a dependency from libmozsandbox to NSPR); currently the first SandboxInfo::Get will occur in SandboxEarlyInit when single-threaded (give or take bug 1222500), but we shouldn't depend on that.
|
||
Updated•5 years ago
|
Severity: normal → S4
Priority: -- → P5
You need to log in
before you can comment on or make changes to this bug.
Description
•