[Regression] class="hostname" text missing in cert error pages

VERIFIED FIXED in Firefox 52

Status

()

VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: yfdyh000, Assigned: Gijs)

Tracking

({regression})

52 Branch
Firefox 54
regression
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox-esr45 unaffected, firefox51 unaffected, firefox52+ verified, firefox53 verified, firefox54 verified)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
STR:
Open a URL to trigger "Your connection is not secure" screen.


Actual result:
"The owner of has configured their website improperly. To protect your information from being stolen, Nightly has not connected to this website." shown, no hostname.

Regression window:
Bug 989197 - Show alternate UI in cert error pages when a captive portal is active. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/7c05b704b149#l1.73
(Reporter)

Comment 1

2 years ago
[Tracking Requested - why for this release]:
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox51: --- → unaffected
status-firefox52: --- → affected
status-firefox53: --- → affected
status-firefox54: --- → affected
status-firefox-esr45: --- → unaffected
tracking-firefox52: --- → ?
Nihanth, do you think you could take a look at this?
Flags: needinfo?(nhnt11)
Comment hidden (mozreview-request)
(Assignee)

Comment 4

2 years ago
It looks like this got removed from both the cert and captive portal case by accident after https://bugzilla.mozilla.org/show_bug.cgi?id=989197#c70 and I didn't notice this in review. :-(

Added a test for it so we don't do it again.
Assignee: nobody → gijskruitbosch+bugs
Component: Location Bar → General
Flags: needinfo?(nhnt11)
(Assignee)

Updated

2 years ago
Attachment #8831534 - Flags: review?(nhnt11)

Comment 5

2 years ago
mozreview-review
Comment on attachment 8831534 [details]
Bug 1334774 - re-introduce the hostname into ssl error messages,

https://reviewboard.mozilla.org/r/108076/#review109756

Thanks! Rather unfortunate oversight, the test should help in the future. :)
Attachment #8831534 - Flags: review?(nhnt11) → review+

Comment 6

2 years ago
mozreview-review
Comment on attachment 8831534 [details]
Bug 1334774 - re-introduce the hostname into ssl error messages,

https://reviewboard.mozilla.org/r/108078/#review109768

Comment 7

2 years ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9d5eba009db7
re-introduce the hostname into ssl error messages, r=nhnt11
(Assignee)

Comment 8

2 years ago
Comment on attachment 8831534 [details]
Bug 1334774 - re-introduce the hostname into ssl error messages,

Approval Request Comment
[Feature/Bug causing the regression]: bug 989197
[User impact if declined]: Broken messaging on a bunch of SSL error pages
[Is this code covered by automated tests?]: it is as part of this patch. It was generally, but it didn't catch this breakage...
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: open e.g.  https://untrusted-root.badssl.com/ and check that the first line of the long description of the error that starts "The owner of ... has configured their website improperly" actually includes the hostname of the site you're accessing (untrusted-root.badssl.com, in this case), and doesn't just go "The owner of has configured their website improperly".
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: no
[Why is the change risky/not risky?]: very small fix that comes with tests!
[String changes made/needed]: no, the string already had a <span> in which the hostname had to go, we just stopped doing that by accident, leaving it empty. Oops. The patch re-starts putting things into that string.
Attachment #8831534 - Flags: approval-mozilla-beta?
Attachment #8831534 - Flags: approval-mozilla-aurora?
Flags: in-testsuite+

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9d5eba009db7
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Hi Andrei,
could you help verify if this issue is fixed as expected on a latest Nightly build? Thanks!
Flags: needinfo?(andrei.vaida)
Forwarding this to Brindusa, who's taking care of requests on the nightly channel.
Flags: qe-verify+
Flags: needinfo?(brindusa.tot)
Flags: needinfo?(andrei.vaida)
Waiting until I can verify the fix in today's nightly in a couple of hours before uplifting.  Tracking for 52 as new UI regression.
tracking-firefox52: ? → +
Comment on attachment 8831534 [details]
Bug 1334774 - re-introduce the hostname into ssl error messages,

fix UI regression from captive portal changes, aurora53+, beta52+

Looks fixed in nightly today.
Attachment #8831534 - Flags: approval-mozilla-beta?
Attachment #8831534 - Flags: approval-mozilla-beta+
Attachment #8831534 - Flags: approval-mozilla-aurora?
Attachment #8831534 - Flags: approval-mozilla-aurora+

Comment 14

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/cd8688f42f8a
status-firefox53: affected → fixed
Verified as fixed with latest Nightly 54.0a1, Build ID 20170202030211 on Windows 7, Ubuntu 16.04 and Mac 10.10.

As a suggestion, it would be nice that hostname to be bold, italic or red color, to be more visible for the user.
Status: RESOLVED → VERIFIED
status-firefox54: fixed → verified
Flags: needinfo?(brindusa.tot)

Comment 16

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/166a10fe355f
status-firefox52: affected → fixed
Verified as fixed using latest Aurora 53.0a2 2017-02-16 under Windows 10 64-bit, Ubuntu 14.04 64-bit and Mac 10.11.6.
status-firefox52: fixed → verified
status-firefox53: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.