Closed Bug 1334774 Opened 6 years ago Closed 6 years ago
[Regression] class="hostname" text missing in cert error pages
STR: Open a URL to trigger "Your connection is not secure" screen. Actual result: "The owner of has configured their website improperly. To protect your information from being stolen, Nightly has not connected to this website." shown, no hostname. Regression window: Bug 989197 - Show alternate UI in cert error pages when a captive portal is active. r=Gijs https://hg.mozilla.org/integration/autoland/rev/7c05b704b149#l1.73
[Tracking Requested - why for this release]:
Nihanth, do you think you could take a look at this?
It looks like this got removed from both the cert and captive portal case by accident after https://bugzilla.mozilla.org/show_bug.cgi?id=989197#c70 and I didn't notice this in review. :-( Added a test for it so we don't do it again.
Assignee: nobody → gijskruitbosch+bugs
Component: Location Bar → General
Attachment #8831534 - Flags: review?(nhnt11)
Comment on attachment 8831534 [details] Bug 1334774 - re-introduce the hostname into ssl error messages, https://reviewboard.mozilla.org/r/108076/#review109756 Thanks! Rather unfortunate oversight, the test should help in the future. :)
Attachment #8831534 - Flags: review?(nhnt11) → review+
Comment on attachment 8831534 [details] Bug 1334774 - re-introduce the hostname into ssl error messages, https://reviewboard.mozilla.org/r/108078/#review109768
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/9d5eba009db7 re-introduce the hostname into ssl error messages, r=nhnt11
Comment on attachment 8831534 [details] Bug 1334774 - re-introduce the hostname into ssl error messages, Approval Request Comment [Feature/Bug causing the regression]: bug 989197 [User impact if declined]: Broken messaging on a bunch of SSL error pages [Is this code covered by automated tests?]: it is as part of this patch. It was generally, but it didn't catch this breakage... [Has the fix been verified in Nightly?]: not yet [Needs manual test from QE? If yes, steps to reproduce]: open e.g. https://untrusted-root.badssl.com/ and check that the first line of the long description of the error that starts "The owner of ... has configured their website improperly" actually includes the hostname of the site you're accessing (untrusted-root.badssl.com, in this case), and doesn't just go "The owner of has configured their website improperly". [List of other uplifts needed for the feature/fix]: n/a [Is the change risky?]: no [Why is the change risky/not risky?]: very small fix that comes with tests! [String changes made/needed]: no, the string already had a <span> in which the hostname had to go, we just stopped doing that by accident, leaving it empty. Oops. The patch re-starts putting things into that string.
Hi Andrei, could you help verify if this issue is fixed as expected on a latest Nightly build? Thanks!
Forwarding this to Brindusa, who's taking care of requests on the nightly channel.
Waiting until I can verify the fix in today's nightly in a couple of hours before uplifting. Tracking for 52 as new UI regression.
Comment on attachment 8831534 [details] Bug 1334774 - re-introduce the hostname into ssl error messages, fix UI regression from captive portal changes, aurora53+, beta52+ Looks fixed in nightly today.
Verified as fixed with latest Nightly 54.0a1, Build ID 20170202030211 on Windows 7, Ubuntu 16.04 and Mac 10.10. As a suggestion, it would be nice that hostname to be bold, italic or red color, to be more visible for the user.
Verified as fixed using latest Aurora 53.0a2 2017-02-16 under Windows 10 64-bit, Ubuntu 14.04 64-bit and Mac 10.11.6.
You need to log in before you can comment on or make changes to this bug.