nsWindow.cpp: redundant return statement at the end of a function with a void return type

RESOLVED FIXED in Firefox 55

Status

()

defect
P5
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sylvestre, Assigned: nitishplus98, Mentored)

Tracking

(Blocks 1 bug, {good-first-bug})

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox54 wontfix, firefox55 fixed)

Details

(Whiteboard: [lang=C++][tpi:+])

Attachments

(1 attachment)

(Reporter)

Updated

2 years ago
Keywords: good-first-bug
Whiteboard: [good first bug][lang=C++] → [lang=C++]
(Reporter)

Comment 2

2 years ago
Comment on attachment 8831514 [details]
Bug 1334795 - nsWindow.cpp: remove two redundant return statements at the ends of functions with void return type.

Good work, now please find a reviewer:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_4_-_Get_your_code_reviewed
Attachment #8831514 - Flags: feedback+
(Reporter)

Updated

2 years ago
Assignee: nobody → nitishplus98
(Assignee)

Comment 3

2 years ago
Thanks for assigning the bug.
Will you be willing to review it if I add you as a reviewer?
(Assignee)

Updated

2 years ago
Attachment #8831514 - Flags: review?(karlt)

Comment 5

2 years ago
mozreview-review
Comment on attachment 8831514 [details]
Bug 1334795 - nsWindow.cpp: remove two redundant return statements at the ends of functions with void return type.

https://reviewboard.mozilla.org/r/108070/#review111778

::: widget/gtk/nsWindow.cpp
(Diff revision 1)
>  
>      if (mIsTopLevel || mListenForResizes) {
>          DispatchResized();
>      }
> -
> -    return;

> removed two redundant return statements at the end of a function with a void return type

Please use imperative mood instead of indicative, and make "end" and "function" plural.

"remove two redundant return statements at the ends of functions with void return type"
Attachment #8831514 - Flags: review?(karlt) → review+
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8831514 - Flags: review?(karlt)

Updated

2 years ago
Priority: -- → P5
Whiteboard: [lang=C++] → [lang=C++][tpi:+]
Comment on attachment 8831514 [details]
Bug 1334795 - nsWindow.cpp: remove two redundant return statements at the ends of functions with void return type.

I don't know why mozreview removed the f+ and r+, sorry.
Attachment #8831514 - Flags: review?(karlt) → review+

Comment 8

2 years ago
Hello I am a new developer.Can I work on this bug?
(Reporter)

Comment 9

2 years ago
noise
Sorry but someone has been working on this already.
(Assignee)

Comment 10

2 years ago
noise
Is there anything else to do, like adding tests?
(Reporter)

Comment 11

2 years ago
You should mark Karl's comment as "Fixed" in the review:
https://reviewboard.mozilla.org/r/108070/#issue-summary

Then, either do:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_6_-_Actually_get_the_code_into_the_tree

Or ask me to land it for you through mozreview & autoland (I cannot do it for you as you haven't closed the review)
(Assignee)

Comment 12

2 years ago
Marked the comment as "Fixed". A small query,is the marking done to ensure that the person working on it has fixed the reopened issue?

Comment 13

2 years ago
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9e21c2dc1b0d
nsWindow.cpp: remove two redundant return statements at the ends of functions with void return type. r=karlt

Comment 14

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9e21c2dc1b0d
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.