1334795 - nsWindow.cpp: redundant return statement at the end of a function with a void return type

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P5)

Description

[Sylvestre Ledru [:Sylvestre]]

This is a very easy good first bug for a beginner.

The following return; declarations are useless as we are at the end of the function/method

https://dxr.mozilla.org/mozilla-central/source/widget/gtk/nsWindow.cpp?q=widget%2Fgtk%2FnsWindow.cpp&redirect_type=direct#1134
https://dxr.mozilla.org/mozilla-central/source/widget/gtk/nsWindow.cpp?q=widget%2Fgtk%2FnsWindow.cpp&redirect_type=direct#1164

Comment 1

[Nitish]

Attachment: Bug 1334795 - nsWindow.cpp: remove two redundant return statements at the ends of functions with void return type.

Review commit: https://reviewboard.mozilla.org/r/108070/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108070/

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8831514 [details]
Bug 1334795 - nsWindow.cpp: remove two redundant return statements at the ends of functions with void return type.

Good work, now please find a reviewer:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_4_-_Get_your_code_reviewed

Comment 3

[Nitish]

Thanks for assigning the bug.
Will you be willing to review it if I add you as a reviewer?

Comment 4

[Sylvestre Ledru [:Sylvestre]]

You need to find a component owner:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_4_-_Get_your_code_reviewed

Comment 5

[Karl Tomlinson (:karlt)]

Comment on attachment 8831514 [details]
Bug 1334795 - nsWindow.cpp: remove two redundant return statements at the ends of functions with void return type.

https://reviewboard.mozilla.org/r/108070/#review111778

::: widget/gtk/nsWindow.cpp
(Diff revision 1)
>  
>      if (mIsTopLevel || mListenForResizes) {
>          DispatchResized();
>      }
> -
> -    return;

> removed two redundant return statements at the end of a function with a void return type

Please use imperative mood instead of indicative, and make "end" and "function" plural.

"remove two redundant return statements at the ends of functions with void return type"

Comment 6

[Nitish]

Comment on attachment 8831514 [details]
Bug 1334795 - nsWindow.cpp: remove two redundant return statements at the ends of functions with void return type.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/108070/diff/1-2/

Comment 7

[Karl Tomlinson (:karlt)]

Comment on attachment 8831514 [details]
Bug 1334795 - nsWindow.cpp: remove two redundant return statements at the ends of functions with void return type.

I don't know why mozreview removed the f+ and r+, sorry.

Comment 8

[Shashwat Mishra]

Hello I am a new developer.Can I work on this bug?

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Sorry but someone has been working on this already.

Comment 10

[Nitish]

Is there anything else to do, like adding tests?

Comment 11

[Sylvestre Ledru [:Sylvestre]]

You should mark Karl's comment as "Fixed" in the review:
https://reviewboard.mozilla.org/r/108070/#issue-summary

Then, either do:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_6_-_Actually_get_the_code_into_the_tree

Or ask me to land it for you through mozreview & autoland (I cannot do it for you as you haven't closed the review)

Comment 12

[Nitish]

Marked the comment as "Fixed". A small query,is the marking done to ensure that the person working on it has fixed the reopened issue?

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e21c2dc1b0d
nsWindow.cpp: remove two redundant return statements at the ends of functions with void return type. r=karlt

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9e21c2dc1b0d