Remove Windows XP support from toolkit/xre/

RESOLVED FIXED in Firefox 54

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: emk, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
mozilla54
Unspecified
Windows XP
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8831499 [details]
Bug 1334866 - Remove Windows XP support from toolkit/xre/.

https://reviewboard.mozilla.org/r/108036/#review109318

I see that the current block is xp-only, but on aurora it is still for all Windows. So we need to keep some way to re-enable that check easily.

::: toolkit/xre/nsAppRunner.cpp:4846
(Diff revision 1)
>  enum {
>    kE10sEnabledByUser = 0,
>    kE10sEnabledByDefault = 1,
>    kE10sDisabledByUser = 2,
>    // kE10sDisabledInSafeMode = 3, was removed in bug 1172491.
> -  kE10sDisabledForAccessibility = 4,
> +  // kE10sDisabledForAccessibility = 4, removed due to xp-eol

This doesn't seem right: e10s+a11y is still unstable and isn't riding the trains, so keeping this status seems necessary.
Attachment #8831499 - Flags: review?(benjamin) → review-
Comment hidden (mozreview-request)
(Reporter)

Comment 4

2 years ago
mozreview-review-reply
Comment on attachment 8831499 [details]
Bug 1334866 - Remove Windows XP support from toolkit/xre/.

https://reviewboard.mozilla.org/r/108036/#review109318

Restored kE10sDisabledForAccessibility.

> This doesn't seem right: e10s+a11y is still unstable and isn't riding the trains, so keeping this status seems necessary.

Restored the block. Instead, I replaced !IsVistaOrLater() with false because it will always return false anyway.

Comment 5

2 years ago
mozreview-review
Comment on attachment 8831499 [details]
Bug 1334866 - Remove Windows XP support from toolkit/xre/.

https://reviewboard.mozilla.org/r/108036/#review110594
Attachment #8831499 - Flags: review?(benjamin) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 8

2 years ago
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/002c3310a039
Remove Windows XP support from toolkit/xre/. r=bsmedberg

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/002c3310a039
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.