Remove useless version check from PDMFactory

RESOLVED FIXED in Firefox 54

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: emk, Unassigned)

Tracking

(Blocks: 1 bug)

50 Branch
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
https://dxr.mozilla.org/mozilla-central/rev/e7b795db8b5b20c472d8070030e9b08c99a01db6/dom/media/platforms/PDMFactory.cpp#371-378

IsVistaOrLater() uses VerifyVersionInfo() which is not affected by compatibility mode. So this check is useless. I'll remove this check to unblock bug 1325368.
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8831503 [details]
Bug 1334870 - Remove useless version check from PDMFactory.

https://reviewboard.mozilla.org/r/108044/#review109456
Attachment #8831503 - Flags: review?(cpearce) → review+

Comment 3

2 years ago
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/962c947c1e50
Remove useless version check from PDMFactory. r=cpearce

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/962c947c1e50
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.