Closed Bug 1334870 Opened 6 years ago Closed 6 years ago

Remove useless version check from PDMFactory

Categories

(Core :: Audio/Video: Playback, defect)

Product:
Core
Component:
Audio/Video: Playback
Version:
50 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: emk, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1334870 - Remove useless version check from PDMFactory.
59 bytes, text/x-review-board-request
cpearce
: review+
Details 
https://dxr.mozilla.org/mozilla-central/rev/e7b795db8b5b20c472d8070030e9b08c99a01db6/dom/media/platforms/PDMFactory.cpp#371-378

IsVistaOrLater() uses VerifyVersionInfo() which is not affected by compatibility mode. So this check is useless. I'll remove this check to unblock bug 1325368.
Comment on attachment 8831503 [details]
Bug 1334870 - Remove useless version check from PDMFactory.

https://reviewboard.mozilla.org/r/108044/#review109456
Attachment #8831503 - Flags: review?(cpearce) → review+
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/962c947c1e50
Remove useless version check from PDMFactory. r=cpearce
https://hg.mozilla.org/mozilla-central/rev/962c947c1e50
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.