1334893 - Reloading a Temporary add-on resets the applied Theme to default

Status: RESOLVED FIXED

(DevTools :: about:debugging, defect)

Description

[M8R-p7]

STR:
0. Create a new profile.
1. Open the Add-ons Manager.
2. Activate a theme other than Default. [1]
3. Open about:debugging.
4. Click 'Load Temporary Add-on' and choose an add-on to load. [2]
5. Click the 'Reload' button next the the chosen add-on's entry.

Actual Results:
As a side-effect the active theme is un-applied, revealing the Default theme.
The selected theme is still listed as active in the Add-ons Manager, and restarting the browser will restore the correct theme.

Expected Results:
Reloading an unrelated add-on shouldn't affect the applied theme.

Vague regression range:
54.0a1 2017-01-24 - Expected Results
54.0a1 2017-01-25 - Actual Results

[1] Lightweight or Compact. Heavyweight themes may not be affected, or it may just not be visible.
[2] e.g. Something from the WebExtensions Examples repo: https://github.com/mdn/webextensions-examples

Comment 1

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c2ebea0623f7a2b2da31c761894296fccb24cfa0
Bug 1334893: Don't reset theme styling when non-theme extension shuts down. r=aswan

Comment 2

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c2ebea0623f7

Comment 3

[Sayed [:LiquidO2]]

I have reproduced this bug with Nightly 54.0a1 (2017-01-29) (64-bit) on Manjaro 16 (64-bit).

Verified as fixed with Latest Nightly 54.0a1

Build ID 	20170202110108
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0

[bugday-20170201]