1334942 - Port Bug 1331983 - Avoid non-smart string IDL types in nsIX509CertDB.idl to c-c

Status: RESOLVED FIXED

(MailNews Core :: Security: S/MIME, defect)

Description

[:Cykesiopka]

Bug 1331983 makes changes to various method types and parameter counts that require c-c changes as well.

Comment 1

[:Cykesiopka]

Attachment: bug1334942_c-c-nsix509certdb-no-raw-string_v1.patch

This builds fine locally, and try looks OK-ish:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=fa1a4080b6a768369a9e70a6c467abef9e40a63a
... but I haven't tested manually.

Feel free to redirect review.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8835538 [details] [diff] [review]
bug1334942_c-c-nsix509certdb-no-raw-string_v1.patch

Review of attachment 8835538 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you very much. Looks good to me. So a few string types have changed here, right?

::: mailnews/mime/src/nsCMS.cpp
@@ -205,4 @@
>  {
> -  nsNSSShutDownPreventionLock locker;
> -  if (isAlreadyShutDown())
> -    return NS_ERROR_NOT_AVAILABLE;

Can you explain this, please.

Comment 3

[:Cykesiopka]

(In reply to Jorg K (GMT+1) from comment #2)
> Thank you very much. Looks good to me. So a few string types have changed
> here, right?

Thanks for the review.

Yes, the APIs affected have switched from taking a |char*| to |nsACString|.
The only interesting API change is ConstructX509(), which loses its explicit length param, since nsACString already implicitly specifies the length.

> ::: mailnews/mime/src/nsCMS.cpp
> @@ -205,4 @@
> >  {
> > -  nsNSSShutDownPreventionLock locker;
> > -  if (isAlreadyShutDown())
> > -    return NS_ERROR_NOT_AVAILABLE;
> 
> Can you explain this, please.

See the commit message - this fixes a -Wmisleading-indentation warning.

I also got rid of the NSS shutdown stuff because there's no point in having it there if the functionality is not actually implemented.

Comment 4

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/56f01236297049e3895d11c7f763481545c46722