Make all layout/reftests/bugs/315920-* tests use MozReftestInvalidate instead of onload

NEW
Unassigned

Status

()

P3
normal
2 years ago
3 months ago

People

(Reporter: mats, Unassigned)

Tracking

({good-first-bug})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=html] )

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
layout/reftests/bugs/315920-17.html failed when it became the first test to run
in a reftest chunk, so I fixed it in bug 1330962 like so:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b222ec9a5d90805a8bb0e8bcdfbc3a34d42bbbc0

I see that the other 315920-* tests are similar, so this is an accident
waiting to happen once one of the other tests becomes the first test.
We should fix all of them in a similar way.
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8841795 [details]
Bug 1334944 - Make all layout/reftests/bugs/315920-* tests use MozReftestInvalidate instead of onload

https://reviewboard.mozilla.org/r/115896/#review117284

::: layout/reftests/bugs/315920-22.html:23
(Diff revision 1)
>      </div>
> +    <script>
> +    function doTest() {
> +      var elem = document.getElementById("one");
> +      elem.setAttribute("disabled", "disabled");
> +      document.getElementById("two").removeAttribute("disabled")

I was unsure if I should leave the trailing semicolon missing when moving this around.

::: layout/reftests/bugs/315920-23.html:24
(Diff revision 1)
>    </body>
> +    <script>
> +    function doTest() {
> +      var elem = document.getElementById("one");
> +      elem.setAttribute("disabled", "disabled");
> +      document.getElementById("two").removeAttribute("disabled")

Same for this missing semicolon.
Hmm, tests are failing on Linux with this...
Do all of these tests show at least one checked checkbox/radio when the load (so that the image load happens)?  Otherwise waiting for the MozReftestInvalidate doesn't seem like it would wait for an image load triggered *by* the dynamic changes.  (But also see bug 1342240 comment 20.)
:kwierso, thanks for writing a patch for this- is there a chance you could try comment 20 from bug 1342240 out?  Do you need any help?
Flags: needinfo?(wkocher)
I actually don't have a whole lot of time to work on this, if someone else can take it from here, that'd be great.
Flags: needinfo?(wkocher)
as a note, I just added fuzzy-if for the common failures in bug 1342240, we can remove those along with a fix here :)
(Reporter)

Comment 8

2 years ago
Comment on attachment 8841795 [details]
Bug 1334944 - Make all layout/reftests/bugs/315920-* tests use MozReftestInvalidate instead of onload

I think this is unnecessary now that we've backed out the code that made
the checkmark a background image from all branches (bug 1357169 and bug 1352406).
Attachment #8841795 - Flags: review?(mats)
Priority: -- → P3

Comment 9

3 months ago
Hello,
I'm an absolute beginner and would like to work on this bug.
You need to log in before you can comment on or make changes to this bug.