1334952 - [ShowFor] Mac OS X Firefox 51 erroneously shows Android, Android FF50.1 erroneously shows Linux

Status: RESOLVED INVALID

(support.mozilla.org - Lithium :: General, defect, P1)

Description

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

Attachment: erroneously showing firefox for android 50 and above on firefox 51.0.1 for mac - 32478677941_ee9b6f9679_o.png

+++ is this related to Bug #1328563 ? +++

Steps to Reproduce:

1. surf to "28January2017 test showfor article" (link https://hwsfp35778.lithium.com/t5/Basic-Browsing/28January2017-test-showfor-article/ta-p/3) on Mac OS X Firefox 51 and Firefox 50.1 Android

Expected Results:
1. only see Android content on Firefox Android AND
onlye see Mac OS X content on Mac OS X 

Actual Results:

1. I erroneously see Android content on MBP 13" 2015 Mac OS X 10.11.6 Firefox 51.0.1
AND
on Android Firefox 50.1 , Pixel XL Android 7.1.1 I erroneously see Linux content

See attached Screenshots

Comment 1

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

Attachment: Firefox 50.1 still showing Linux erroneously Screenshot_20170129-185624.png 32222158400_cfc6325839_o.png

Comment 2

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

scott perhaps this is a bug in my test article?

Comment 3

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

test article is: https://hwsfp35778.lithium.com/t5/Basic-Browsing/28January2017-test-showfor-article/ta-p/3

Comment 4

[Tyson Nunemacher]

The "data-for" attributes in the content look reasonable.  The actual toggling is handled by Mozilla's showfor.js script, unchanged from your old site.  Can you create the same article on the old site and see if the behavior is different?

Comment 5

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

tyson: by 'old site' you mean kitsune, right? i'll try that now

Comment 6

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

BEGIN TEST ARTICLE MARKUP SOURCE (from: https://support.mozilla.org/en-US/kb/01february2017-testing-osx-android-showfor )
{for m50}This is for Fx for Android 50 and above.{/for}

{for fx50}
Firefox 50 and above:
{for win, fx50}This is for Windows {/for}
{for mac,fx50}This is for Mac.{/for}
{/for}
END

ff 51.0.1, mac os x screenshot: https://www.flickr.com/photos/roland/32497943002
ff 51.0.1, windows 10screenshot: https://www.flickr.com/photos/roland/32610716256/
ff 50.1 android, pixel screenshot: https://www.flickr.com/photos/roland/32651271095/
ff 6.0 for ios, os x 10.2.1: https://www.flickr.com/photos/roland/32498236162/

Tyson it appears that showfor for Android is broken on kitsune aka 'the old site'. See screenshots and article markup source above
So it looks like that showfor.js script might be broken. I will file a separate bug for that.

This only affects articles  with Android showfor so I don't think this a blocker. Unblocking.