Closed
Bug 1334954
Opened 7 years ago
Closed 7 years ago
Eliminate nulls in out parameter for nsIURI (StreamMessage)
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(thunderbird52 fixed, thunderbird53 fixed, thunderbird54 fixed)
RESOLVED
FIXED
Thunderbird 54.0
People
(Reporter: rkent, Assigned: rkent)
References
Details
Attachments
(1 file)
|
4.82 KB,
patch
|
jorgk-bmo
:
review+
jorgk-bmo
:
approval-comm-aurora+
jorgk-bmo
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
In bug 1229649, we eliminated nulls as output parameters in most MailNews methods, but neglected to do this for StreamMessage. Without this, any attempt to use a JS version of StreamMessage immediately crashes (affecting JsAccount)
|
Assignee | |
Comment 1•7 years ago
|
||
This just does the same thing we did in the earlier bug.
|
|
Assignee | |
Comment 2•7 years ago
|
||
Comment on attachment 8831597 [details] [diff] [review] use dummyNull Approval Request Comment I'll need this in TB 52. Should have no risk.
Attachment #8831597 -
Flags: approval-mozilla-beta?
Attachment #8831597 -
Flags: approval-mozilla-aurora?
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8831597 [details] [diff] [review] use dummyNull Gotta tick the right box ;-)
Attachment #8831597 -
Flags: review?(jorgk)
Attachment #8831597 -
Flags: review+
Attachment #8831597 -
Flags: approval-mozilla-beta?
Attachment #8831597 -
Flags: approval-mozilla-aurora?
Attachment #8831597 -
Flags: approval-comm-beta+
Attachment #8831597 -
Flags: approval-comm-aurora+
|
|
||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/comm-central/rev/8857b7a3a4cc3ba7c689945676eed3ff5b6c4a19 I needed something to land, so I grabbed this one ;-)
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 54.0
|
|
||
Comment 5•7 years ago
|
||
Aurora (TB 53): https://hg.mozilla.org/releases/comm-aurora/rev/9fc7e7325d3d36466608af568746cd6d785a55a0
status-thunderbird52:
--- → affected
status-thunderbird53:
--- → fixed
status-thunderbird54:
--- → fixed
|
|
||
Comment 6•7 years ago
|
||
Beta (TB 52): https://hg.mozilla.org/releases/comm-beta/rev/b7f5a495b6bd939034bbe2c6e3a6ebf7363f6a6d
You need to log in
before you can comment on or make changes to this bug.
Description
•