Closed Bug 1334954 Opened 4 years ago Closed 4 years ago

Eliminate nulls in out parameter for nsIURI (StreamMessage)

Categories

(MailNews Core :: Backend, defect)

defect
Not set
normal

Tracking

(thunderbird52 fixed, thunderbird53 fixed, thunderbird54 fixed)

RESOLVED FIXED
Thunderbird 54.0
Tracking Status
thunderbird52 --- fixed
thunderbird53 --- fixed
thunderbird54 --- fixed

People

(Reporter: rkent, Assigned: rkent)

References

Details

Attachments

(1 file)

In bug 1229649, we eliminated nulls as output parameters in most MailNews methods, but neglected to do this for StreamMessage. Without this, any attempt to use a JS version of StreamMessage immediately crashes (affecting JsAccount)
See Also: → 1229649
Attached patch use dummyNullSplinter Review
This just does the same thing we did in the earlier bug.
Assignee: nobody → rkent
Status: NEW → ASSIGNED
Attachment #8831597 - Flags: review?(jorgk)
Comment on attachment 8831597 [details] [diff] [review]
use dummyNull

Approval Request Comment

I'll need this in TB 52. Should have no risk.
Attachment #8831597 - Flags: approval-mozilla-beta?
Attachment #8831597 - Flags: approval-mozilla-aurora?
Comment on attachment 8831597 [details] [diff] [review]
use dummyNull

Gotta tick the right box ;-)
Attachment #8831597 - Flags: review?(jorgk)
Attachment #8831597 - Flags: review+
Attachment #8831597 - Flags: approval-mozilla-beta?
Attachment #8831597 - Flags: approval-mozilla-aurora?
Attachment #8831597 - Flags: approval-comm-beta+
Attachment #8831597 - Flags: approval-comm-aurora+
https://hg.mozilla.org/comm-central/rev/8857b7a3a4cc3ba7c689945676eed3ff5b6c4a19
I needed something to land, so I grabbed this one ;-)
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 54.0
You need to log in before you can comment on or make changes to this bug.