1334977 - [webvr] Crash in mozilla::gfx::VRSystemManagerOpenVR::ScanForControllers

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Daosheng Mu[:daoshengmu]]

Although I try to fix this crash at Bug 1334310, it still happen crash. I think it is because we set mVRSystem at GetHMDs() after making OpenVR is initialized. Therefore, we should check mVRSystem is nullptr at ScanForControllers() like before (https://reviewboard.mozilla.org/r/106786/diff/3#index_header).

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1334977 - Checking mVRSystem is not nullptr before scannibg OpenVR controllers;

Review commit: https://reviewboard.mozilla.org/r/108170/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108170/

Comment 2

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8831620 [details]
Bug 1334977 - Checking mVRSystem is not nullptr before scannibg OpenVR controllers;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/108170/diff/1-2/

Comment 3

[:kip (Kearwood Gilbert)]

Comment on attachment 8831620 [details]
Bug 1334977 - Checking mVRSystem is not nullptr before scannibg OpenVR controllers;

https://reviewboard.mozilla.org/r/108170/#review109696

LGTM, Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/064f8ea8ee11
Checking mVRSystem is not nullptr before scannibg OpenVR controllers; r=kip

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/064f8ea8ee11