1335002 - A custom search engine can be saved multiple times

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P3)

Description

[Catalin Suciu [:csuciu]]

master 51abcc7

1. Go to Firefox Settings => Search => Add Search Engine.  
2. Type the Title and the URL of a custom search engine.
3. Press on the 'Save' button multiple times.
4. Check the Quick-Search Engines list

Result: The custom search engine is added multiple times.

Comment 1

[Raymond Edwards]

I'd like to contribute here. Working on a pull request now.

Comment 2

[Raymond Edwards]

Attachment: Pull request

Comment 3

[Emily Toop (:fluffyemily)]

Comment on attachment 8843633 [details] [review]
Pull request

Hi, thanks for the patch. It mostly looks good. Resolves the bug criteria well.

One small thing I would like to be added to the code that ensures you cannot add the same engine twice at different times. 

The current code doesn't strip trailing and leading whitespace from either the template or name vars, which means you can still add the same search engine more than once if you add padding. Please can you strip the whitespace before the equality comparison for name and template strings?

Thanks again for the patch.

Comment 4

[Raymond Edwards]

Attachment: Pull request

Good catch. Whitespace is now trimmed before saving.

Comment 5

[Stephan Leroux [:sleroux]]

v7.x b497e7f51160b05d2724cf366d98f1b993b6785f

Comment 6

[Catalin Suciu [:csuciu]]

Verifying as fixed on Firefox Beta 7.0 (1986).