Use PrivacyLevel.jsm for mobile session store

RESOLVED FIXED in Firefox 54

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: JanH, Assigned: JanH)

Tracking

unspecified
Firefox 54
All
Android
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
The desktop session store has moved its code for checking browser.sessionstore.privacy_level into a JSM - we should use it as well.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 3

2 years ago
Comment on attachment 8832193 [details]
Bug 1335008 - Part 1 - Move PrivacyLevel.jsm to toolkit.

Seems like just moving that file into toolkit is not enough, cancelling review until I can update this.
Attachment #8832193 - Flags: review?(mdeboer)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 8

2 years ago
mozreview-review
Comment on attachment 8832194 [details]
Bug 1335008 - Part 2 - Replace our own privacy level check implementation with PrivacyLevel.jsm

https://reviewboard.mozilla.org/r/108526/#review110228

Nice!
Attachment #8832194 - Flags: review?(s.kaspari) → review+

Comment 9

2 years ago
mozreview-review
Comment on attachment 8832193 [details]
Bug 1335008 - Part 1 - Move PrivacyLevel.jsm to toolkit.

https://reviewboard.mozilla.org/r/108524/#review110548

LGTM, thanks!
Attachment #8832193 - Flags: review?(mdeboer) → review+

Comment 11

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/87450805b650
Part 1 - Move PrivacyLevel.jsm to toolkit. r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/d5bf5497ac16
Part 2 - Replace our own privacy level check implementation with PrivacyLevel.jsm r=sebastian
Keywords: checkin-needed

Comment 12

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/87450805b650
https://hg.mozilla.org/mozilla-central/rev/d5bf5497ac16
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.