Closed
Bug 1335010
Opened 4 years ago
Closed 4 years ago
mobile/android/themes/core/config.css uses float: inline-*
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Firefox for Android Graveyard
Theme and Visual Design
Unspecified
Android
Tracking
(firefox51 unaffected, firefox52 unaffected, firefox53+ fixed, firefox54+ fixed)
RESOLVED
FIXED
Firefox 54
Tracking | Status | |
---|---|---|
firefox51 | --- | unaffected |
firefox52 | --- | unaffected |
firefox53 | + | fixed |
firefox54 | + | fixed |
People
(Reporter: tomer, Assigned: tomer)
References
()
Details
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
sebastian
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
… May cause test failures on beta and release while layout.css.float-logical-values.enabled is not enabled there.
Comment hidden (mozreview-request) |
Comment 2•4 years ago
|
||
mozreview-review |
Comment on attachment 8831679 [details] Bug 1335010 - mobile/android/themes/core/config.css uses float: inline-* https://reviewboard.mozilla.org/r/108232/#review109242
Attachment #8831679 -
Flags: review?(s.kaspari) → review+
Assignee | ||
Comment 3•4 years ago
|
||
[Tracking Requested - why for this release]:
status-firefox51:
--- → unaffected
status-firefox52:
--- → unaffected
status-firefox53:
--- → affected
status-firefox54:
--- → affected
tracking-firefox53:
--- → ?
tracking-firefox54:
--- → ?
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/db25ecf790ee mobile/android/themes/core/config.css uses float: inline-* r=sebastian
Keywords: checkin-needed
Assignee | ||
Comment 5•4 years ago
|
||
(In reply to Tomer Cohen :tomer from comment #3) > [Tracking Requested - why for this release]: This change is required for beta and up because layout.css.float-logical-values.enabled is preffed off and will cause test failures.
Comment 7•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/db25ecf790ee
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment 8•4 years ago
|
||
Please request Aurora approval on this at your earliest convenience :)
Flags: needinfo?(tomer.moz.bugs)
Assignee | ||
Comment 9•4 years ago
|
||
Comment on attachment 8831679 [details] Bug 1335010 - mobile/android/themes/core/config.css uses float: inline-* Approval Request Comment [Feature/Bug causing the regression]: bug 1298904 [User impact if declined]: test failures [Is this code covered by automated tests?]: no, but it cause failures due to unimplemented keywords. [Has the fix been verified in Nightly?]: yes. [Needs manual test from QE? If yes, steps to reproduce]: probably not [List of other uplifts needed for the feature/fix]: no dependencies beside bug 1298904 which this patch fix. [Is the change risky?]: not too much. [Why is the change risky/not risky?]: Just backporting CSS code to use :dir(). [String changes made/needed]:
Flags: needinfo?(tomer.moz.bugs)
Attachment #8831679 -
Flags: approval-mozilla-aurora?
Comment on attachment 8831679 [details] Bug 1335010 - mobile/android/themes/core/config.css uses float: inline-* Simple fix, broke in 53, let's uplift to aurora.
Attachment #8831679 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•4 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/f42494856f83
Updated•2 months ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•