1335028 - Use https for access to hg.mozilla.org in c-c build files.

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Frank-Rainer Grahl (:frg)]

Replace http://hg.mozilla.org with https://hg.mozilla.org

From a posting in mozilla.dev.apps.seamonkey:

> in .planning it was announced that connections to hg.mozilla.org via
> http:// are not longer accepted after 1.2.2017. It must now be https://.

I am still seeing some references in m-c code so not sure if this date is final but it won't hurt to do it now.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1335028-hgmozillaorg.patch

Setting version in debugQA so that it autoupdates.

Comment 2

[Frank-Rainer Grahl (:frg)]

Jorg,

I am seeing some references in mail too. And one test there. Can do a patch if you want in this or another bug. Hartmut Figge reported it including the date.

Comment 3

[Jorg K (CEST = GMT+2)]

Thanks for the heads-up. Yes, can you please do a patch with r?aleth in this bug as long as you change the description to:
  Use https for access to hg.mozilla.org in C-C build files.
I know very little about this.

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: 1335028-hgmozillaorg-mail-im.patch

All I found in im, mail and mailnews. Mostly comments and I am not sure the IM variables are still in use. If it really will be effective Feburary 1 it would need an uplift but I didn't see anything about it yet.

Comment 5

[aleth [:aleth]]

Comment on attachment 8831747 [details] [diff] [review]
1335028-hgmozillaorg-mail-im.patch

Review of attachment 8831747 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 6

[Philip Chee]

Comment on attachment 8831690 [details] [diff] [review]
1335028-hgmozillaorg.patch

r=me a=me

Comment 7

[Philip Chee]

Comment on attachment 8831747 [details] [diff] [review]
1335028-hgmozillaorg-mail-im.patch

From the other patch:
> -    // ",".  See also <http://hg.mozilla.org/mozilla-central/diff/9b2a99adc05e/netwerk/protocol/http/src/nsHttpHeaderArray.cpp#l77>
> +    // ",".  See also <https://hg.mozilla.org/mozilla-central/diff/9b2a99adc05e/netwerk/protocol/http/src/nsHttpHeaderArray.cpp#l77>
Maybe use 40 char hashes?

Comment 8

[Frank-Rainer Grahl (:frg)]

> Maybe use 40 char hashes?

hg didn't like me. Unable to get them out in time. That was the initial cvs to hg push.

https://hg.mozilla.org/comm-central/rev/fd1bd7431d81f9fba0dd1979720f00183bd770d4
https://hg.mozilla.org/comm-central/rev/6eeaa5555802a5545f03e497b239f8e46c2ad9c4

Comment 9

[Frank-Rainer Grahl (:frg)]

Just found the actual bug 450645

Should we uplift in advance or wait and see if the redirect works?