Closed
Bug 1335029
Opened 7 years ago
Closed 7 years ago
Crash in mozilla::MediaStreamGraphImpl::ApplyAudioContextOperationImpl
Categories
(Core :: Audio/Video: MediaStreamGraph, defect, P1)
Tracking
()
People
(Reporter: jesup, Assigned: padenot)
Details
(Keywords: crash, csectype-nullptr)
Crash Data
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
jesup
:
review+
gchang
:
approval-mozilla-beta+
|
Details |
This bug was filed from the Socorro interface and is report bp-f2633ae1-a651-45dc-a438-0e97a2170130. ============================================================= This is crashing when it's doing a Resume, and 'switching' is true, but nextdriver is nullptr (which should never happen) Pretty high crash frequency (~400 in the last week). Most (but not all) are on android.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → padenot
Reporter | ||
Updated•7 years ago
|
Rank: 23
Priority: -- → P2
Comment 1•7 years ago
|
||
Crash volume for signature 'mozilla::MediaStreamGraphImpl::ApplyAudioContextOperationImpl': - nightly (version 54): 1 crash from 2017-01-23. - aurora (version 53): 0 crashes from 2017-01-23. - beta (version 52): 3 crashes from 2017-01-23. - release (version 51): 19 crashes from 2017-01-16. - esr (version 45): 1744 crashes from 2016-08-10. Crash volume on the last weeks (Week N is from 02-06 to 02-12): W. N-1 W. N-2 W. N-3 W. N-4 W. N-5 W. N-6 W. N-7 - nightly 0 0 - aurora 0 0 - beta 1 2 - release 12 5 0 - esr 68 88 51 67 36 30 30 Affected platforms: Windows, Mac OS X Crash rank on the last 7 days: Browser Content Plugin - nightly #1002 - aurora - beta #8171 #2414 - release #4378 #1616 - esr #172
status-firefox51:
--- → affected
status-firefox52:
--- → affected
status-firefox54:
--- → affected
status-firefox-esr45:
--- → affected
Comment 2•7 years ago
|
||
Mass wontfix for bugs affecting firefox 52.
Assignee | ||
Comment 3•7 years ago
|
||
This now happens on windows and osx, bumping to P1.
Priority: P2 → P1
Comment hidden (mozreview-request) |
Reporter | ||
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8902674 [details] Bug 1335029 - Take into account SystemClockDrivers in fallback mode when dealing with AudioContext promises. https://reviewboard.mozilla.org/r/174348/#review179588
Attachment #8902674 -
Flags: review?(rjesup) → review+
Pushed by paul@paul.cx: https://hg.mozilla.org/integration/autoland/rev/be5d0598f77d Take into account SystemClockDrivers in fallback mode when dealing with AudioContext promises. r=jesup
Backed out for crashtest failures like https://treeherder.mozilla.org/logviewer.html#?job_id=127110405&repo=autoland https://hg.mozilla.org/integration/autoland/rev/f8e18499448edab80c1e6a0083b573a3e323975e
Flags: needinfo?(padenot)
Pushed by paul@paul.cx: https://hg.mozilla.org/integration/mozilla-inbound/rev/048c89a84fa0 Take into account SystemClockDrivers in fallback mode when dealing with AudioContext promises. r=jesup
Assignee | ||
Comment 9•7 years ago
|
||
meh I had forgotten either to put a return statement, or an else. Went with an else.
Flags: needinfo?(padenot)
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/048c89a84fa0
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 11•7 years ago
|
||
Doesn't seem worth ESR52 consideration given the low volume. I'm a bit torn on Beta because it's low volume but the patch is also pretty straightforward. What are your thoughts, Paul?
status-firefox55:
--- → wontfix
status-firefox56:
--- → affected
status-firefox-esr52:
--- → wontfix
Flags: needinfo?(padenot)
Assignee | ||
Comment 13•7 years ago
|
||
Comment on attachment 8902674 [details] Bug 1335029 - Take into account SystemClockDrivers in fallback mode when dealing with AudioContext promises. Approval Request Comment [Feature/Bug causing the regression]: bug 1094764 I suppose [User impact if declined]: crash [Is this code covered by automated tests?]: no it only happens when some kind of system limit has been reached and the system can't open new audio streams [Has the fix been verified in Nightly?]: Verified manually by putting the audio stack of the OS in a weird state. [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Cause and fix are well understood, the patch is small. [String changes made/needed]:
Attachment #8902674 -
Flags: approval-mozilla-beta?
Comment 14•7 years ago
|
||
Comment on attachment 8902674 [details] Bug 1335029 - Take into account SystemClockDrivers in fallback mode when dealing with AudioContext promises. Fix a crash. Beta56+.
Attachment #8902674 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 15•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/e1a13a255fcf
You need to log in
before you can comment on or make changes to this bug.
Description
•