1335049 - Some bytecode documentation's stack count doesn't match to actual value.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Fix bytecode documentation stack notation to match nuses/ndefs, and verify it in make_opcode_doc.py.

Fixed "Stack:" in Opcodes.h
  * JSOP_GETPROP_SUPER / JSOP_OPTIMIZE_SPREADCALL
    lack of "," between values
  * JSOP_GOSUB
    this actually pushes values, but when it resumes from next PC,
    those values are popped, and also those values are mentioned in JSOP_FINALLY
    so I think "Stack:" for JSOP_GOSUB shouldn't contain them
  * JSOP_DERIVEDCONSTRUCTOR
    input is prototype for the constructor
  * JSOP_THROWSETCONST / JSOP_THROWSETALIASEDCONST / JSOP_THROWSETCALLEE
    they implicitly use the value for the assignment
  * JSOP_INITIALYIELD
    it keeps generator value on the stack

also added a code to verify count in make_opcode_doc.py.
it doesn't check for following conditions:
  * when one of nuses/ndefs is -1
  * when "Stack:" contains "..."
    this matches to stack operations (JSOP_DUPAT/JSOP_PICK/JSOP_UNPICK)
    and JSOP_INITHOMEOBJECT

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8831706 [details] [diff] [review]
Fix bytecode documentation stack notation to match nuses/ndefs, and verify it in make_opcode_doc.py.

Review of attachment 8831706 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 3

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a2648889cc0355e7ad3cd600ec92ece45327a73a
Bug 1335049 - Fix bytecode documentation stack notation to match nuses/ndefs, and verify it in make_opcode_doc.py. r=jandem

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a2648889cc03