1335123 - Clean up layers logging for WebRenderLayers

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: logging.patch

It's a bit all over the place, and there are a few things we should be logging that we aren't.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8831763 [details] [diff] [review]
logging.patch

Review of attachment 8831763 [details] [diff] [review]:
-----------------------------------------------------------------

Generally looks good, although I'm not sure if anybody is really using this logging anymore.

::: gfx/layers/wr/WebRenderLayersLogging.cpp
@@ +16,5 @@
> +AppendToString(std::stringstream& aStream, WrMixBlendMode aMixBlendMode,
> +               const char* pfx, const char* sfx)
> +{
> +  aStream << pfx;
> +  switch(aMixBlendMode) {

nit: add a space before '('. Ditto for WrTextureFilter

@@ +50,5 @@
> +    aStream << "WrMixBlendMode::Color"; break;
> +  case WrMixBlendMode::Luminosity:
> +    aStream << "WrMixBlendMode::Luminosity"; break;
> +
> +  default:

Can we use |Sentinel| instead of |default| here, so that the compiler will warn us if a new type is added to WrMixBlendMode and this code isn't updated? Ditto for WrTextureFilter.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/12c5788aa7a0
Clean up layers logging for WebRenderLayers. r=kats