Closed Bug 1335161 Opened 3 years ago Closed 2 years ago

Remove specific_tests_zip_dirs functionality from mozharness

Categories

(Release Engineering :: Applications: MozharnessCore, defect, P3)

defect

Tracking

(firefox60 fixed)

RESOLVED FIXED
Tracking Status
firefox60 --- fixed

People

(Reporter: chmanchester, Assigned: vprabhu, Mentored)

References

Details

(Whiteboard: [lang=py][good-first-bug])

Attachments

(1 file)

This hasn't really been useful since we split the test zip, and now that mozharness is in tree there's no cost to tearing it out.

It wasn't ever implemented consistently across platforms, so it can make things hard to track down when it causes problems.
Would this be a good first bug?
Flags: needinfo?(cmanchester)
Priority: -- → P3
Yes, I think so!
Flags: needinfo?(cmanchester)
Whiteboard: [lang=py][good-first-bug]
Hi, I would like to work on this. How can I get started?
Hello. Interested in working on this bug. I'm assuming that this deals with mozilla-central code. If so, where do I begin? Thanks.
Flags: needinfo?(catlee)
Hi,

This function shows up in a few places:
https://searchfox.org/mozilla-central/search?q=specific_tests_zip_dirs&path=

I would first look at removing the function and configuration values, and doing a push to the Try server to test.
Flags: needinfo?(catlee)
Is this still open? I am interested in working on this.
(In reply to venkateshprabhu2 from comment #6)
> Is this still open? I am interested in working on this.

Yes it is. Feel free to pick it up and work on it. See comments above.
(In reply to Leni Kadali [:leni1] [GMT+3] from comment #7)
> (In reply to venkateshprabhu2 from comment #6)
> > Is this still open? I am interested in working on this.
> 
> Yes it is. Feel free to pick it up and work on it. See comments above.

Thank you. Sorry about the delay. I was working on setting up firefox and another first bug. The guidelines recommend the bug to be assigned to me before working on the request. Is it alright if I work on it with the 'unassigned' status?
I've assigned it to you, so go ahead.

:catlee, there was no mentor assigned so I defaulted to you. Do you know of a better mentor for this bug?
Assignee: nobody → venkateshprabhu2
Mentor: catlee
Status: NEW → ASSIGNED
I'm happy to give pointers if needed. Find us in #releng on irc if you have questions!
@Chris, I have requested level 1 commit access to the try server. Can you please vouch for me? Here is the bug link: https://bugzilla.mozilla.org/show_bug.cgi?id=1436656. Thank you!
I have removed the function calls and configuration values, pushed it to the try server. There were no failed jobs. Do I need to run specific jobs in the try server?
Can you link to your try results here?
It wasn't clear me for as to which tests(jobs?) have to be run in the try server. Here is the link of current results:  https://treeherder.mozilla.org/testview.html?repo=try&revision=39e9c022f3e3662097939d435a71bcc9c5f9ea7d.
(In reply to Chris AtLee [:catlee] from comment #13)
> Can you link to your try results here?

Hi Chris,

I have run more tests as you have suggested and the results are here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9d270da252b227022bbba9043e8887e3ffade31
(In reply to Venkatesh Prabhu :vprabhu from comment #15)
> (In reply to Chris AtLee [:catlee] from comment #13)
> > Can you link to your try results here?
> 
> Hi Chris,
> 
> I have run more tests as you have suggested and the results are here:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=c9d270da252b227022bbba9043e8887e3ffade31

That looks good! I looked for failures that looked to be related to downloading and extracting the test zips, and there were none!

The next step is to push your code up for review. There is some documentation here: http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview-user.html
(In reply to Chris AtLee [:catlee] from comment #17)
> I did notice that the linting test failed:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=c9d270da252b227022bbba9043e8887e3ffade31&selectedJob=1
> 62123652&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-
> resultStatus=exception&filter-classifiedState=unclassified
> 
> I think this is referring to the code you commented out here:
> https://hg.mozilla.org/try/rev/b989fea6a039#l5.18
> 
> You can just delete that code instead of commenting it out.

Sure. Thank you for reviewing the test results. I had forgotten to remove those commented code lines. I have submitted the changes now for review. I wasn't sure if I had to put you as reviewer for this. So, I left the 'r?' part out in the commit message. Looking forward to hear the feedback.
Comment on attachment 8951383 [details]
Bug 1335161 - Removed specific_tests_zip_dirs functionality from mozharness.

https://reviewboard.mozilla.org/r/220640/#review226640
Attachment #8951383 - Flags: review+
Pushed by catlee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/51ec07de4837
Removed specific_tests_zip_dirs functionality from mozharness. r=catlee
https://hg.mozilla.org/mozilla-central/rev/51ec07de4837
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.