Closed Bug 1335181 Opened 8 years ago Closed 8 years ago

add BUG_COMPONENT to netwerk/* and dom/network/* files

Categories

(Core :: Networking, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

(Whiteboard: [necko-active])

Attachments

(1 file)

to help match up source and test files to proper bug components we are using BUG_COMPONENT in moz.build so we have a more defined mapping. I see two areas for Core::Networking* dom/network/ * *.cpp * *.h * interfaces/ * tests/ * * * marionette/ netwerk/ * base/ *.idl, *.cpp, *.h, *.js * rust-url-capi/ * src/ * test/ * build/ *.h, *.cpp * cache/ *.h, *.cpp * cache2/ *.h, *.cpp, *.idl * cookie/ *.h, *.cpp, *.idl * test/ * browser/ *.js, *.html * unit/ *.js * unit_ipc/ *.js * dns/ *.h, *.c, *.cpp, *.idl, *.py * mdns/ *.idl * libmdns/ *.h, *.cpp, *.js, *.manifest * fallback/ *.jsm * ipc/ *.h, *.cpp, *.ipdl * locales/en-US/* * mime/ *.h, *.cpp, *.idl * protocol/ * about/ *.h, *.cpp, *.idl * data/ *.h, *.cpp * device/ *.h, *.cpp * file/ *.h, *.cpp, *.idl * ftp/ *.h, *.cpp, *.idl * test/frametest/ *.html (DO WE USE TEST??) * http/ *.h, *.cpp, *.idl, *.js, *.py * res/ *.h, *.cpp, *.idl * viewsource/ *.h, *.cpp, *.idl * websocket/ *.h, *.cpp, *.idl * wyciwyg/ *.h, *.cpp, *.ipdl * sctp/ *.sh * src/ *.h * netinet/ *.h, *.c * netinet6/ *.h, *.c * datachannel/ *.h, *.cpp * socket/ *.h, *.cpp, *.idl * srtp/ *.sh * src/ * crypto/ (subdirs and *.h, *.c files) * include/ *.h * srtp/ *.c * standalone/ *.h, *.cpp * streamconv/ *.h, *.cpp, *.idl * converters/ *.h, *.cpp * parse-ftp/ *.in, *.out * system/ * android/ *.h, *.cpp * linux/ *.h, *.cpp * mac/ *.h, *.mm * win32/ *.h, *.cpp * test/ *.h, *.cpp * browser/ *.js, *.html * crashtest/ *.html * gtest/ *.cpp * httpserver/ *.js, *.manifest, *.idl * test/ *.js * data/ (more subdirs) * mochitests/ *.html, *.sjs * reftest/ *.html * unit/ *.js * data/ *.txt * unit_ipc/ *.js * wifi/ *.h, *.cpp, *.idl In bugzilla, I see a few possible components: Core::Networking Core::Networking: Cache Core::Networking: Cookies Core::Networking: DNS Core::Networking: Domain Lists Core::Networking: File Core::Networking: FTP Core::Networking: HTTP Core::Networking: JAR Core::Networking: Websockets some look obvious to match up to components, but others I assume are just Core::Networking, if there are directories here that do not belong in networking, or should be in a subdomain, let me know!
my attempt to pick the correct components.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8831806 - Flags: review?(mcmanus)
Comment on attachment 8831806 [details] [diff] [review] add BUG_COMPONENT to dom/network/* and netwerk/* Review of attachment 8831806 [details] [diff] [review]: ----------------------------------------------------------------- lgtm. thanks joel
Attachment #8831806 - Flags: review?(mcmanus) → review+
Whiteboard: [necko-active]
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5ef2c6652fca add BUG_COMPONENT to netwerk/* and dom/network/* files. r=mcmanus
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: