Closed Bug 1335202 Opened 4 years ago Closed 4 years ago

Enable crashtests for QR builds in automation

Categories

(Core :: Graphics: WebRender, defect, P3)

Product:
Core
Component:
Graphics: WebRender
Version:
Other Branch
Platform:
x86_64
Linux
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Bug 1335202 - Enable crashtests on QR builds in automation.
59 bytes, text/x-review-board-request
rhunt
: review+
Details 
There's three crashtest failures, all of which are because of too-large textures that webrender doesn't handle yet. Bug 1322816 is already on file for having webrender support this. We can just disable those three failures and turn on the crashtest suite.
Comment on attachment 8831839 [details]
Bug 1335202 - Enable crashtests on QR builds in automation.

There's still a failure in the try run, because of fewer assertions than expected. I'll update the patch.
Attachment #8831839 - Flags: review?(graphics-team)
The "fewer assertions" is on layout/printing/crashtests/576878.xhtml - the test is annotated as asserts-if(browserIsRemote,4) but the expected assertions (which are bug 765972 and bug 1232856) don't happen with webrender. So I intend to add a asserts-if(webrender,0) clause to silence the warning.
Comment on attachment 8831839 [details]
Bug 1335202 - Enable crashtests on QR builds in automation.

https://reviewboard.mozilla.org/r/108358/#review109652
Attachment #8831839 - Flags: review?(rhunt) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/84b84e7610ee
Enable crashtests on QR builds in automation. r=rhunt
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.