Closed Bug 1335236 Opened 3 years ago Closed 2 years ago
_Telemetry Send .js | test _discard Big Pings - [test _discard Big Pings : 338] Should have recorded send success time . - 0 > 0
59 bytes, text/x-review-board-request
we have >50 failures in the last week on windows. :gfritzsche, could you help find someone who knows about telemetry or this test case to look into it in the next week or two?
Whiteboard: [stockwell needswork]
I just got back from PTO and currently swamped with the backlog, but I will try to get here ASAP. Leaving the ni? around.
:dexter, any progress on this (or at least your backlog and coming back to this)?
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #13) > :dexter, any progress on this (or at least your backlog and coming back to > this)? No progress, that's currently in my backlog.
Priority: P2 → P1
This is funny and interesting :-D I added some debug prints to the Telemetry code responsible of populating the probe . It turns out that, in the intermittently failing test, the telemetry code  and the local ping server became so fast that the time it takes to send a ping a receive a reply is 0, on every affected failing build (which are opt or pgo). Yay/D'oh! > INFO - TEST-PASS | toolkit/components/telemetry/tests/unit/test_TelemetrySend.js | test_discardBigPings - [test_discardBigPings : 339] Should have recorded send success time. - 1 == 1 > NING - TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_TelemetrySend.js | test_discardBigPings - [test_discardBigPings : 340] Should have recorded send success time. - 0 > 0 > INFO - Z:/task_1503930516/build/tests/xpcshell/tests/toolkit/components/telemetry/tests/unit/test_TelemetrySend.js:test_discardBigPings:340 The interesting part comes nearby: > INFO - PID 1488 | **** DEBUG - _onPingRequestFinished testTime: 42385.886999999995 - startTime 42385.886999999995  - https://treeherder.mozilla.org/#/jobs?repo=try&revision=50842503c2b7f4faf155f7f6983202b5431e522f&selectedJob=126456303  - https://treeherder.mozilla.org/logviewer.html#?job_id=126456303&repo=try&lineNumber=12523  - http://searchfox.org/mozilla-central/rev/18c16ebf818abb86805ce08a6e537e4cd826f044/toolkit/components/telemetry/TelemetrySend.jsm#1013
wow, that is a fast ping :)
Comment on attachment 8901880 [details] Bug 1335236 - Fix intermittent test_TelemetrySend.js due to flaky time tests. https://reviewboard.mozilla.org/r/173310/#review178680
Attachment #8901880 - Flags: review?(chutten) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/af4b93c96f15 Fix intermittent test_TelemetrySend.js due to flaky time tests. r=chutten
Whiteboard: [stockwell needswork] → [stockwell fixed:logic]
You need to log in before you can comment on or make changes to this bug.