Closed
Bug 1335236
Opened 7 years ago
Closed 7 years ago
Intermittent toolkit/components/telemetry/tests/unit/test_TelemetrySend.js | test_discardBigPings - [test_discardBigPings : 338] Should have recorded send success time. - 0 > 0
Categories
(Toolkit :: Telemetry, defect, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla57
People
(Reporter: intermittent-bug-filer, Assigned: Dexter)
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:logic])
Attachments
(1 file)
Filed by: philringnalda [at] gmail.com https://treeherder.mozilla.org/logviewer.html#?job_id=73033249&repo=mozilla-beta https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-beta-win64-pgo/1485787302/mozilla-beta_win8_64_test_pgo-xpcshell-bm109-tests1-windows-build0.txt.gz
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 8•7 years ago
|
||
we have >50 failures in the last week on windows. :gfritzsche, could you help find someone who knows about telemetry or this test case to look into it in the next week or two?
Flags: needinfo?(gfritzsche)
Whiteboard: [stockwell needswork]
Updated•7 years ago
|
status-firefox56:
--- → affected
status-firefox57:
--- → affected
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Flags: needinfo?(alessio.placitelli)
Assignee | ||
Comment 11•7 years ago
|
||
I just got back from PTO and currently swamped with the backlog, but I will try to get here ASAP. Leaving the ni? around.
Comment hidden (Intermittent Failures Robot) |
Comment 13•7 years ago
|
||
:dexter, any progress on this (or at least your backlog and coming back to this)?
Assignee | ||
Comment 14•7 years ago
|
||
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #13) > :dexter, any progress on this (or at least your backlog and coming back to > this)? No progress, that's currently in my backlog.
Assignee | ||
Updated•7 years ago
|
Priority: -- → P2
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(alessio.placitelli)
Priority: P2 → P1
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(gfritzsche)
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → alessio.placitelli
Assignee | ||
Comment 16•7 years ago
|
||
This is funny and interesting :-D I added some debug prints to the Telemetry code responsible of populating the probe [1]. It turns out that, in the intermittently failing test, the telemetry code [3] and the local ping server became so fast that the time it takes to send a ping a receive a reply is 0, on every affected failing build (which are opt or pgo). Yay/D'oh! > INFO - TEST-PASS | toolkit/components/telemetry/tests/unit/test_TelemetrySend.js | test_discardBigPings - [test_discardBigPings : 339] Should have recorded send success time. - 1 == 1 > NING - TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_TelemetrySend.js | test_discardBigPings - [test_discardBigPings : 340] Should have recorded send success time. - 0 > 0 > INFO - Z:/task_1503930516/build/tests/xpcshell/tests/toolkit/components/telemetry/tests/unit/test_TelemetrySend.js:test_discardBigPings:340 The interesting part comes nearby: > INFO - PID 1488 | **** DEBUG - _onPingRequestFinished testTime: 42385.886999999995 - startTime 42385.886999999995 [1] - https://treeherder.mozilla.org/#/jobs?repo=try&revision=50842503c2b7f4faf155f7f6983202b5431e522f&selectedJob=126456303 [2] - https://treeherder.mozilla.org/logviewer.html#?job_id=126456303&repo=try&lineNumber=12523 [3] - http://searchfox.org/mozilla-central/rev/18c16ebf818abb86805ce08a6e537e4cd826f044/toolkit/components/telemetry/TelemetrySend.jsm#1013
Comment 17•7 years ago
|
||
wow, that is a fast ping :)
Comment hidden (mozreview-request) |
Comment 19•7 years ago
|
||
mozreview-review |
Comment on attachment 8901880 [details] Bug 1335236 - Fix intermittent test_TelemetrySend.js due to flaky time tests. https://reviewboard.mozilla.org/r/173310/#review178680
Attachment #8901880 -
Flags: review?(chutten) → review+
Comment 20•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/af4b93c96f15 Fix intermittent test_TelemetrySend.js due to flaky time tests. r=chutten
Comment 21•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/fe81d9af21d6
Comment 22•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/af4b93c96f15
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•7 years ago
|
Whiteboard: [stockwell needswork] → [stockwell fixed:logic]
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•