Closed Bug 1335240 Opened 3 years ago Closed 3 years ago

actions.InputState does not record correct type for key and pointer

Categories

(Testing :: Marionette, defect)

Version 3
defect
Not set

Tracking

(firefox52 fixed, firefox-esr52 fixed, firefox53 fixed, firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox52 --- fixed
firefox-esr52 --- fixed
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: maja_zf, Assigned: maja_zf)

Details

Attachments

(1 file)

When you create a new input state like `x = new action.InputState.Key()`, then x.type is "inputstate" instead of "key".
Comment on attachment 8831871 [details]
Bug 1335240 - actions.InputState does not record correct type for key and pointer;

https://reviewboard.mozilla.org/r/108372/#review109980

::: testing/marionette/test_action.js:385
(Diff revision 1)
>  
> +add_test(function test_createInputState() {
> +  for (let kind in action.InputState) {
> +    let state = new action.InputState[kind]();
> +    ok(state);
> +    if (kind == "Null") {

Use triple `===` here so we also get type check.
Attachment #8831871 - Flags: review?(ato) → review+
Pushed by mjzffr@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/035696fd9f95
actions.InputState does not record correct type for key and pointer; r=ato
https://hg.mozilla.org/mozilla-central/rev/035696fd9f95
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Test-only uplift to aurora and esr52, please. (To avoid backward-compatibility fixes in Marionette Client.)
Whiteboard: [checkin-needed-aurora][checkin-needed-esr52]
https://hg.mozilla.org/releases/mozilla-aurora/rev/5f7f4b00b19f
Flags: in-testsuite+
Whiteboard: [checkin-needed-aurora][checkin-needed-esr52] → [checkin-needed-esr52]
You need to log in before you can comment on or make changes to this bug.