Closed Bug 1335266 Opened 7 years ago Closed 6 years ago

Intermittent dom/svg/test/test_fragments.html | Test timed out.

Categories

(Core :: SVG, defect)

Product:
Core
Component:
SVG
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox60 --- fixed
firefox61 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: dholbert)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:other])

Attachments

(1 file, 1 obsolete file)

Bug 1335266: In test_fragments.html, don't set iframe src attribute until *after* we've set up its load handler.
59 bytes, text/x-review-board-request
longsonr
: review+
Details
Status: NEW → RESOLVED
Closed: 7 years ago
Keywords: bulk-close-intermittents
Resolution: --- → INCOMPLETE
Fail reappeared on autoland 

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=164969669&repo=autoland&lineNumber=4344
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
In the last 7 days, there have been 30 failures.

The failures are on Linux, Linux x64, Windows 7 and a few on windows10-64, linux64-qr, linux64-nightly platforms.
Affected build types: debug, opt, pgo.

An example of a recent log file:
https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=167771068&lineNumber=4314

And the relevant part of the log:
20:23:53     INFO -  1056 INFO TEST-START | dom/svg/test/test_fragments.html
20:29:20     INFO -  TEST-INFO | started process screenshot
20:29:20     INFO -  TEST-INFO | screenshot: exit 0
20:29:20    ERROR -  1057 INFO TEST-UNEXPECTED-FAIL | dom/svg/test/test_fragments.html | Test timed out.
20:29:20     INFO -      reportError@SimpleTest/TestRunner.js:121:7
20:29:20     INFO -      TestRunner._checkForHangs@SimpleTest/TestRunner.js:142:7
20:29:20     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
20:29:20     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
20:29:20     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
20:29:20     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
20:29:20     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
20:29:20     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
20:29:20     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
20:29:20     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
20:29:20     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
20:29:20     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
20:29:20     INFO -      setTimeout handler*TestRunner._checkForHangs@SimpleTest/TestRunner.js:163:5
20:29:20     INFO -      TestRunner.runTests@SimpleTest/TestRunner.js:380:5
20:29:20     INFO -      RunSet.runtests@SimpleTest/setup.js:194:3
20:29:20     INFO -      RunSet.runall@SimpleTest/setup.js:173:5
20:29:20     INFO -      hookupTests@SimpleTest/setup.js:266:5
20:29:20     INFO -  parseTestManifest@http://mochi.test:8888/manifestLibrary.js:36:5
20:29:20     INFO -  getTestManifest/req.onload@http://mochi.test:8888/manifestLibrary.js:49:11
20:29:20     INFO -  EventHandlerNonNull*getTestManifest@http://mochi.test:8888/manifestLibrary.js:45:3
20:29:20     INFO -      hookup@SimpleTest/setup.js:246:5
20:29:20     INFO -  EventHandlerNonNull*@http://mochi.test:8888/tests?autorun=1&closeWhenDone=1&consoleLevel=INFO&manifestFile=tests.json&dumpOutputDirectory=c%3A%5Cusers%5Cgenericworker%5Cappdata%5Clocal%5Ctemp&cleanupCrashes=true:11:1

:jet As you are the triage owner of this component, could you please take a look at this?
Thank you!
Flags: needinfo?(bugs)
Whiteboard: [stockwell needswork]
Robert: can you tell why this test is hanging on us? Thx!
Flags: needinfo?(bugs) → needinfo?(longsonr)
Attached patch patch (obsolete) — — Splinter Review 
Maybe it just takes a long time, it tests lots of cases.
Flags: needinfo?(longsonr)
Attachment #8960734 - Flags: review?(dholbert)
Comment on attachment 8960734 [details] [diff] [review]
patch

Review of attachment 8960734 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm, I'm not confident that's the answer.

I picked one of the platforms with a failure (test-linux64/opt-mochitest-e10s-3) and I looked at a recent non-failing (green) log from that platform. I found this:
> TEST-OK | dom/svg/test/test_fragments.html | took 174ms
https://treeherder.mozilla.org/logviewer.html#?job_id=169453531&repo=mozilla-central&lineNumber=4434

That duration (174ms) seems pretty fast, and several orders of magnitude away from 300 seconds (which IIRC is the timeout that requestLongerTimeout would be doubling here).

So unfortunately I don't think this would help.
Attachment #8960734 - Flags: review?(dholbert) → review-
Looks like the test has this:
> <iframe id="svg" src="fragments-helper.svg"></iframe>
> [...]
> <script class="testbody" type="application/javascript">
> [...]
> $(svg).addEventListener("load", runTests);

I wonder if maybe the <iframe> is loading faster than we expect -- specifically, maybe it's firing its load event *before* we get to parsing/running the <script> block? (before we get a chance to register the load handler)  So then runTests would never execute, and we'd never call SimpleTest.finish().

If that's the problem, I expect we could fix this bug by leaving the iframe's src attribute empty, and then setting it after we've set up the load handler (so that its load is more directly guaranteed to trigger the load handler). Let's give that a shot. I'll post a patch in a minute...
Comment on attachment 8961049 [details]
Bug 1335266: In test_fragments.html, don't set iframe src attribute until *after* we've set up its load handler.

https://reviewboard.mozilla.org/r/229796/#review235592
Attachment #8961049 - Flags: review?(longsonr) → review+
Thanks! I tested this locally and the test still passes, so I went ahead and triggered autoland. We'll see if it helps, I guess.
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f2cb8bff5402
In test_fragments.html, don't set iframe src attribute until *after* we've set up its load handler. r=longsonr
Attachment #8960734 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/f2cb8bff5402
Status: REOPENED → RESOLVED
Closed: 7 years ago → 6 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Assignee: nobody → dholbert
status-firefox60: --- → affected
Keywords: bulk-close-intermittents
Whiteboard: [stockwell needswork] → [stockwell fixed:other]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: