1335332 - Autocomplete UI appears in wrong position when autofocusing on non-empty username field before CSS has finished loading

Status: RESOLVED DUPLICATE of bug 1329333

(Toolkit :: Password Manager, defect, P2)

Description

[Alexey]

Attachment: After page load

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170124094647

Steps to reproduce:

1) Open login form which contains input field with "autofocus" attribute. Nothing special in this form (no absolute positioning etc.). Tested on 2 different forms.
2) The similar problem: open https://github.com/login



Actual results:

1) Password autocomplete list appears in a wrong position. If we click the mouse into the field autocomplete list repositions to the right position. Maybe it's because the list positioned BEFORE styles loaded?
2) Password autocomplete list takes whe whole width of the page. Everything is OK after mouseclick


Expected results:

1) Password autocomplete list should appear right after the field, as it does if we focus element by the mouse.
2) Password autocomplete list should respect the width of the input field

Comment 1

[Loic]

I tried on https://github.com/login with Nightly, I can't reproduce it: http://i.imgur.com/eydSDy7.jpg

Do you have a page link to reproduce it?

Are you using a special theme on your Win 10?

Comment 2

[Alexey]

I wrote a screencast on GitHub login page. As you can see sometimes autocomplete list displays correctly (I think it depends on CSS load). I have caching disabled.
I don't use any special Windows themes. And it's not an insider preview.
Here is a link on another website where I can see the similar problrm: http://oko44.ru/admin

Comment 3

[Alexey]

Attachment: GitHub login page screencast

Comment 4

[Loic]

Do you have cache disabled in normal mode? If yes, how did you disable it?
With network.http.use-cache=false?

I know PB mode has cache disabled (like in your screencast indeed).

Comment 5

[Loic]

Nevermind, I'm able to reproduce it in Nightly (in normal or PB mode, whatever).

Comment 6

[Loic]

I used your website login page and I pressed F5 many times to reproduce it.

Comment 7

[Alexey]

Maybe it depends on network connection speed? I tried to emulate slow connection using new Responsive design mode from Developer tools, but unfornanately logins autocomplete list doesn't initially appear at all when Developer tools are open

Comment 8

[Loic]

No, it's due to the autocomplete UI displayed on autofocus non-empty field when the CSS sheet is still loading.
In your case, without full CSS, the pwd field is displayed temporarily on the top left and the autocomplete UI too due to autofocus.

Before the regression, you can replicate it manually by clicking VERY quickly on the input field to display the autocomplete UI.

The regression is due to:
Dale Harvey — Bug 1311301 - Ensure login managed inputs focus on load. r=mattn
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9b8bf5feb0b52aa4b03aa5fa3d4f0727b2974663&tochange=b49684127ce464141b0a989cd621cb4794b6a85f

I think it could be fixed by bug 1325437.

Comment 9

[Loic]

Attachment: autocomplete-UI-wrong-place.jpg

Comment 10

[Astley Chen (inactive)]

(In reply to Loic from comment #8)
> I think it could be fixed by bug 1325437.

Matt, status-firefox52 in bug 1325437 was labeled as fix-optional.
Would you think this regression is likely to be fixed by triggering another reflow after loading style sheet? Or any suggestion to progress this bug ?
Thanks.

Comment 11

[Dale Harvey (:daleharvey)]

I am happy to investigate and try out fixes for this, however it seems like content moving / loading is something this should already handle so I would like to hear from someone who knows the code (hi Matt) about whether this is a regression or where to look at a fix

Comment 12

[Matthew N. [:MattN]]

I believe this is a regression form e10s-ification because the popup is now in a different process from the input so can't use the `anchor` feature of popups to automatically follow the input as it moves. I believe the same problem may also apply to form validation popups and maybe <select> ones too, if not we should copy their solution(s). I believe we would need something like IntersectionObserver or some other API for the parent process to be notified of position changes (ideally without polling).

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Matt, from discussion in the platform triage meeting, it sounds like we would need some UI work or decisions here and it's a bigger project than we should try to fix in 52 or even 53. Can you take this on or find someone to work on it for the 54/55 timeframe?

Comment 14

[Alexey]

I've noticed the similar bug while I maximized the browser window during the page load. Autocomplete list appeared in the position where it has to be before maximizing. See attachments

Comment 15

[Alexey]

Attachment: 2017-02-17 14_30_43-Вход в панель управления для клиентов хостинг-провайдера BeGet. Приятной работы..png

Comment 16

[Alexey]

Attachment: 2017-02-17 14_31_26-Вход в панель управления для клиентов хостинг-провайдера BeGet. Приятной работы..png

Comment 17

[Gerry Chang [:gchang]]

Mark 54 fix-optional as there are no actions for the moment but still happy to have the fix in 54.

Comment 18

[Matthew N. [:MattN]]

I have no time to work on this… I'm going to escalate to get password manager issues fixed.