Closed Bug 1335336 Opened 3 years ago Closed 3 years ago

Handle WebRenderLayerManager in RenderFrameParent

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file)

RenderFrameParent does not handle WebRenderLayerManager well.
Basically only ClientLayerManager is handled.
Blocks: 1335335
Assignee: nobody → sotaro.ikeda.g
Attachment #8831974 - Flags: review?(nical.bugzilla)
Attachment #8831974 - Flags: review?(nical.bugzilla) → review+
Comment on attachment 8831974 [details] [diff] [review]
patch - Add LayerManager::GetCompositorBridgeChild()

Review of attachment 8831974 [details] [diff] [review]:
-----------------------------------------------------------------

Don't you need to provide an implementation of the WebRenderLayerManager function?
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #3)
> -----------------------------------------------------------------
> 
> Don't you need to provide an implementation of the WebRenderLayerManager
> function?

:kats, can you explain more about it?

In RenderFrameParent, WebRenderLayerManager and ClientLayerManager are used just to get CompositorBridgeChild. Then there seem no necessity of WebRenderLayerManager specific implementation.
Flags: needinfo?(bugmail)
Oh, sorry, I misread the patch. I thought you were adding a new function to WebRenderLayerManager. Instead you're just making the existing one virtual.
Flags: needinfo?(bugmail)
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/f92dff831676
Add LayerManager::GetCompositorBridgeChild() r=nical
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.