Remove nsNativeTheme::IsButtonTypeMenu

RESOLVED FIXED in Firefox 54

Status

()

Core
Layout: Form Controls
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: annevk, Assigned: mstange)

Tracking

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
<button type=menu>test</button> has special rendering on macOS due to nsNativeTheme::IsButtonTypeMenu existing. That's a bug. Potentially a leftover from an earlier removal?

Discovered in https://github.com/whatwg/html/issues/237.
This is a regression from bug 508724.
Blocks: 508724

Comment 2

a year ago
I've added a reftest for this in https://github.com/w3c/web-platform-tests/pull/4769
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8836148 - Flags: review?(enndeakin)

Updated

a year ago
Attachment #8836148 - Flags: review?(enndeakin) → review+

Comment 4

a year ago
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/370de9349dd0
Restrict special <button type="menu"> theming to XUL <button> elements. r=Enn

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/370de9349dd0
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54

Updated

a year ago
Assignee: nobody → mstange
You need to log in before you can comment on or make changes to this bug.