1335373 - Removing a site from Top Sites via context menu in landscape does not have proper functionality

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Simon Basca [:SimonB]]

Build: 51abcc7c
Device: iPhone 7
iOS: 10.2

Prerequisites:
- Visit a few sites for example: Google.com, bugzilla.org, facebook.com, youtube.com

Steps to reproduce: 
1. Open a new tab
2. Change device orientation to landscape 
3. Long tap on facebook.com site from Top Sites
4. Tap 'Remove'
5. Long tap on buzilla.org site from Top Sites
6. Tap 'Remove' 

Actual results:
- buzilla.org is not deleted when the device is in landscape view. 

Expected results: 
- buzilla.org should be deleted. 

See video: 
- https://www.youtube.com/watch?v=BmhEIvxavh8

Comment 1

[Farhan Patel [:farhan]]

Could you please check this again on the latest master. Works for me on 
https://github.com/mozilla-mobile/firefox-ios/commit/9f913780eed0842c78c840a2b7a4afae96d59cac

Comment 2

[Simon Basca [:SimonB]]

Tested on latest master 9f91378. 

I have manage to find alternative steps to reproduce this issue on a clean install:

1. Open Firefox
2. Change device orientation to landscape
3. Long tap on facebook.com from Top Sites
4. Tap 'Remove'

Comment 3

[Farhan Patel [:farhan]]

Attachment: Pull Request

Comment 4

[Bryan Munar (:bkmunar)]

Wait... it works for me on current master already, Simon's STR doesn't reproduce the bug issue. Can we double check that this still occurs before merging in this patch?

Comment 5

[Farhan Patel [:farhan]]

Yup it does happen for me. You need a smaller device sometimes to reproduce. It happens for me all the time on my iPhone SE.

Comment 6

[Bryan Munar (:bkmunar)]

Ah yes, I just had to try it more, thanks!

Comment 7

[Farhan Patel [:farhan]]

master https://github.com/mozilla-mobile/firefox-ios/commit/1e2aef02e1fd03c1f4e48c2b4b99719172dae3af

Comment 8

[Simon Basca [:SimonB]]

Verifying as fix on master b3b12590beb.