1335457 - Enable test_switch_tabs_for_new_background_window_without_focus_change (test_switch_window_chrome.py) on Linux / OS X

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With my patch on bug 1124604 I will add a new test which strangely doesn't work on Linux. The newly opened window is not getting pushed to the background and as such the test is failing.

We should investigate why Marionette is not able to open a background window. When I tested it via Scratchpad all is working as expected.

Comment 1

[Brendan Dahl [:bdahl]]

FWIW, I tried to get this test working on headless as well and it seems z-ordering of windows is pretty inconsistent across the various platforms. I imagine this test is broken on windows do to broken z ordering on linux[1]. On the Windows platform with headless, I see the same behavior as linux where the background windows is always foreground. There also is some platform specific code for handling focus on Windows [2] that complicates things as well.

[1] http://searchfox.org/mozilla-central/rev/12afa8cc9cea4a141494f767541b411845eef7a0/browser/modules/RecentWindow.jsm#39
[2] http://searchfox.org/mozilla-central/rev/12afa8cc9cea4a141494f767541b411845eef7a0/dom/base/nsFocusManager.cpp#2277

Comment 2

[Brendan Dahl [:bdahl]]

> I imagine this test is broken on windows do to broken z ordering on linux[1]

Should be "I imagine this test is broken on linux do to broken z ordering[1]"

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The z-order issue on Linux is actually covered by bug 156333. So that's what we would depend on I assume for non-headless tests. Why it's failing for Windows headless I cannot say.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Please note that this is also a problem with MacOS when Firefox runs in background. So I will also disable the test for that platform.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is fixed by bug 1506796. Thanks Gijs!