Closed Bug 1335489 Opened 5 years ago Closed 5 years ago

[wasm] Debugger.Script's lineCount fails or returns wrong value

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: yury, Assigned: yury)

References

Details

Attachments

(1 file)

There is a typo which causes lineCount getter at Debugger.cpp to fail.

And while we at it, let's make lineCount consistent when debugger is disabled and when allowUnobservedAsmJS == true. In first case we return 0, in second size of the experimental text warning (12 lines).
Comment on attachment 8832142 [details]
Bug 1335489 - Fixes Debugger.Script lineCount getter behavior.

https://reviewboard.mozilla.org/r/108498/#review109764
Attachment #8832142 - Flags: review?(luke) → review+
Pushed by ydelendik@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a8643fc32164
Fixes Debugger.Script lineCount getter behavior. r=luke
https://hg.mozilla.org/mozilla-central/rev/a8643fc32164
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.