Closed
Bug 1335527
Opened 7 years ago
Closed 7 years ago
Fix missing typelib dependencies in a11y
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox54 fixed)
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: bugzilla, Assigned: bugzilla)
Details
Attachments
(1 file)
IA2, IGeckoCustom, ISimpleDOMNode don't mention the .tlb files as being generated by midl. I think this is causing problems when making an idl change and building incrementally.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8832202 [details] Bug 1335527: Fix missing entries for .tlb files generated by midl in a11y code; https://reviewboard.mozilla.org/r/108540/#review110010 LGTM - what problems were you hitting in incremental builds? Was there an error or were things not updating properly?
Attachment #8832202 -
Flags: review?(mshal) → review+
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → aklotz
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•7 years ago
|
||
(In reply to Michael Shal [:mshal] from comment #2) > Comment on attachment 8832202 [details] > LGTM - what problems were you hitting in incremental builds? Was there an > error or were things not updating properly? Eitan was hitting runtime errors in COM after making IDL changes, which suggested to me that his .tlb file was out of date.
Pushed by aklotz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1601ad2ba1a9 Fix missing entries for .tlb files generated by midl in a11y code; r=mshal
I had to back this out for build bustage on at least Windows: https://treeherder.mozilla.org/logviewer.html#?job_id=73639331&repo=autoland https://hg.mozilla.org/integration/autoland/rev/5ab245bd3ab573e36983c4c3d9d3b88f0be59dd9
Flags: needinfo?(aklotz)
|
|
Assignee | |
Comment 6•7 years ago
|
||
Grr... looks like this is going to require further investigation.
Flags: needinfo?(aklotz)
|
|
Assignee | |
Comment 7•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/45651363c8d62b522a2e18d93b65fba42a28f4df Bug 1335527: Fix missing entries for .tlb files generated by midl in a11y code; r=mshal
|
|
Assignee | |
Comment 8•7 years ago
|
||
I needed to prefix the proper path to the typelib idl. Problem fixed.
|
|
Assignee | |
Comment 9•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/feb1d8e5b192765cc9ad6fad93464df1e35150df Bug 1335527: Backed out changeset 45651363c8d6 due to bustage; r=bustage
|
|
Assignee | |
Comment 10•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6306054ca94ae845b3c0f56792c9ffbba206cb80 Bug 1335527: Fix missing entries for .tlb files generated by midl in a11y code; r=mshal
|
|
Assignee | |
Comment 11•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c659888e6865879b88999e3aedfe292d776e8cff Bug 1335527: Backed out changeset 6306054ca94a for bustage; r=bustage
|
|
Assignee | |
Comment 12•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b133611326a5
|
|
Assignee | |
Comment 13•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/100a66c377f297e3bb43d6edb73960368e6a137e Bug 1335527: Fix missing entries for .tlb files generated by midl in a11y code; r=mshal
|
||
Comment 14•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6306054ca94a https://hg.mozilla.org/mozilla-central/rev/c659888e6865 https://hg.mozilla.org/mozilla-central/rev/100a66c377f2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•