Closed Bug 1335527 Opened 3 years ago Closed 3 years ago

Fix missing typelib dependencies in a11y

Categories

(Firefox Build System :: General, defect)

Unspecified
Windows
defect
Not set

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

Details

Attachments

(1 file)

IA2, IGeckoCustom, ISimpleDOMNode don't mention the .tlb files as being generated by midl. I think this is causing problems when making an idl change and building incrementally.
Comment on attachment 8832202 [details]
Bug 1335527: Fix missing entries for .tlb files generated by midl in a11y code;

https://reviewboard.mozilla.org/r/108540/#review110010

LGTM - what problems were you hitting in incremental builds? Was there an error or were things not updating properly?
Attachment #8832202 - Flags: review?(mshal) → review+
Assignee: nobody → aklotz
Status: NEW → ASSIGNED
(In reply to Michael Shal [:mshal] from comment #2)
> Comment on attachment 8832202 [details]
> LGTM - what problems were you hitting in incremental builds? Was there an
> error or were things not updating properly?

Eitan was hitting runtime errors in COM after making IDL changes, which suggested to me that his .tlb file was out of date.
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1601ad2ba1a9
Fix missing entries for .tlb files generated by midl in a11y code; r=mshal
Grr... looks like this is going to require further investigation.
Flags: needinfo?(aklotz)
I needed to prefix the proper path to the typelib idl. Problem fixed.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.