Closed
Bug 1335539
Opened 7 years ago
Closed 7 years ago
Get rid of nsIDOMWindowUtils.wrapDOMFile
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
Details
Attachments
(1 file)
57.89 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
This patch has been reviewed elsewhere by Gijs. I added the existenceCheck attribute in the CTOR for the MockFilePicker. Can you, smaug, take a look at that part?
Assignee: nobody → amarchesini
Attachment #8832214 -
Flags: review?(bugs)
Comment 2•7 years ago
|
||
Comment on attachment 8832214 [details] [diff] [review] patch I don't know what aExistenceCheck is about and why it is needed.
Flags: needinfo?(amarchesini)
Comment 3•7 years ago
|
||
Comment on attachment 8832214 [details] [diff] [review] patch r+ I guess. I don't know what all Gijs had already reviewed though.
Attachment #8832214 -
Flags: review?(bugs) → review+
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/952f0a7824ad Get rid of nsIDOMWindowUtils.wrapDOMFile, r=smaug, r=Gijs
Comment 5•7 years ago
|
||
backed out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=e3c55cc9ffa36a578224bbcdd0c4b2c8a886908a for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=78979951&repo=mozilla-inbound not sure if this changes cause this or the others
Flags: needinfo?(amarchesini)
Backout by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e0f8fed31104 Backed out changeset 952f0a7824ad
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c32c74847eb6 Get rid of nsIDOMWindowUtils.wrapDOMFile, r=smaug, r=Gijs
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(amarchesini)
Comment 8•7 years ago
|
||
Had to back this out so bug 1334975 could be backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/f70a2f2dea090c3d717d26a1818a45172b0d3a91
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/429ff39f3d28 Get rid of nsIDOMWindowUtils.wrapDOMFile, r=smaug, r=Gijs
I had to back this out because it caused merge conflicts for me merging inbound to mozilla-central. Can you rebase your patch and reland it? https://hg.mozilla.org/mozilla-central/rev/63c4e77cfe90e90d35d85e1a4821015823c4ecee
Comment 11•7 years ago
|
||
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e769531b2433 Get rid of nsIDOMWindowUtils.wrapDOMFile, r=smaug, r=Gijs
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(amarchesini)
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e769531b2433
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•