Closed Bug 1335539 Opened 7 years ago Closed 7 years ago

Get rid of nsIDOMWindowUtils.wrapDOMFile

Categories

(Core :: DOM: Core & HTML, defect)

49 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(1 file)

      No description provided.
Attached patch patchSplinter Review
This patch has been reviewed elsewhere by Gijs. I added the existenceCheck attribute in the CTOR for the MockFilePicker. Can you, smaug, take a look at that part?
Assignee: nobody → amarchesini
Attachment #8832214 - Flags: review?(bugs)
Comment on attachment 8832214 [details] [diff] [review]
patch

I don't know what aExistenceCheck is about and why it is needed.
Flags: needinfo?(amarchesini)
Comment on attachment 8832214 [details] [diff] [review]
patch

r+ I guess. I don't know what all Gijs had already reviewed though.
Attachment #8832214 - Flags: review?(bugs) → review+
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/952f0a7824ad
Get rid of nsIDOMWindowUtils.wrapDOMFile, r=smaug, r=Gijs
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c32c74847eb6
Get rid of nsIDOMWindowUtils.wrapDOMFile, r=smaug, r=Gijs
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/429ff39f3d28
Get rid of nsIDOMWindowUtils.wrapDOMFile, r=smaug, r=Gijs
I had to back this out because it caused merge conflicts for me merging inbound to mozilla-central. Can you rebase your patch and reland it?
https://hg.mozilla.org/mozilla-central/rev/63c4e77cfe90e90d35d85e1a4821015823c4ecee
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e769531b2433
Get rid of nsIDOMWindowUtils.wrapDOMFile, r=smaug, r=Gijs
Flags: needinfo?(amarchesini)
https://hg.mozilla.org/mozilla-central/rev/e769531b2433
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.