1335543 - EME Tests don't bail when encountering a no key error (but it looks like the author's original intent that they do)

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P5)

Description

[jay.harris]

It looks like:
```
     if (key) {
        Log(token, "found key " + key + " for key id " + idHex);
        outKeys.push({
          "kty":"oct",
          "kid":id64,
          "k":HexToBase64(key)
        });
      } else {
        bail(token + " couldn't find key for key id " + idHex);
      }
```

should be

```
     if (key) {
        Log(token, "found key " + key + " for key id " + idHex);
        outKeys.push({
          "kty":"oct",
          "kid":id64,
          "k":HexToBase64(key)
        });
      } else {
        bail(token + " couldn't find key for key id " + idHex)("No key");
      }
```

As bail returns a function, so nothing actually happens when invoking 'bail'

Comment 1

[jay.harris]

A try build is running https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb3c51169b9c0f9e12cda4f2ca21e84ea6c2e268 to see whether this change will effect any existing tests.

Comment 2

[jay.harris]

Attachment: Bug 1335543 - Calls the bail function

Review commit: https://reviewboard.mozilla.org/r/108640/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108640/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8832302 [details]
Bug 1335543 - Calls the bail function

https://reviewboard.mozilla.org/r/108640/#review110468

good catch!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76265c3faf1e
Calls the bail function r=jwwang

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/76265c3faf1e