Closed Bug 1335543 Opened 4 years ago Closed 4 years ago

EME Tests don't bail when encountering a no key error (but it looks like the author's original intent that they do)

Categories

(Core :: Audio/Video: Playback, defect, P5)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: jay.harris, Assigned: jay.harris)

Details

Attachments

(1 file)

Bug 1335543 - Calls the bail function
59 bytes, text/x-review-board-request
jwwang
: review+
Details 
It looks like:
```
     if (key) {
        Log(token, "found key " + key + " for key id " + idHex);
        outKeys.push({
          "kty":"oct",
          "kid":id64,
          "k":HexToBase64(key)
        });
      } else {
        bail(token + " couldn't find key for key id " + idHex);
      }
```

should be

```
     if (key) {
        Log(token, "found key " + key + " for key id " + idHex);
        outKeys.push({
          "kty":"oct",
          "kid":id64,
          "k":HexToBase64(key)
        });
      } else {
        bail(token + " couldn't find key for key id " + idHex)("No key");
      }
```

As bail returns a function, so nothing actually happens when invoking 'bail'
A try build is running https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb3c51169b9c0f9e12cda4f2ca21e84ea6c2e268 to see whether this change will effect any existing tests.
Attachment #8832302 - Flags: review?(jwwang)
Comment on attachment 8832302 [details]
Bug 1335543 - Calls the bail function

https://reviewboard.mozilla.org/r/108640/#review110468

good catch!
Attachment #8832302 - Flags: review?(jwwang) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/76265c3faf1e
Calls the bail function r=jwwang
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/76265c3faf1e
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.