1335578 - Crash deleting or forwarding mail in [thunk]:mozilla::storage::Connection::`vcall''{100, {flat}}'' }'' via `anonymous namespace'::SyncRunnable2

Status: RESOLVED DUPLICATE of bug 1335638

(MailNews Core :: Networking: IMAP, defect)

Description

[Wayne Mery (:wsmwk)]

Perhaps fallout from an uplift?
#3 crash for 45.7.0 ***
#14 crash for 52.0b1
#11 crash for 51.0b2
 
report bp-b91c9c26-d75a-4d42-a082-a6a392170129 deleting mail
 0 	xul.dll	[thunk]:mozilla::storage::Connection::`vcall'{100, {flat}}' }'	
1 	xul.dll	`anonymous namespace'::SyncRunnable2<nsIImapServerSink, nsAString_internal const&, nsIMsgMailNewsUrl*>::Run()	c:/builds/moz2_slave/tb-rel-c-esr45-w32_bld-0000000/build/mailnews/imap/src/nsSyncRunnableHelpers.cpp:146
2 	xul.dll	nsThread::ProcessNextEvent(bool, bool*)	xpcom/threads/nsThread.cpp:972
3 	xul.dll	NS_ProcessNextEvent(nsIThread*, bool)	xpcom/glue/nsThreadUtils.cpp:297
4 	xul.dll	MessageLoop::RunHandler()	ipc/chromium/src/base/message_loop.cc:227
5 	xul.dll	nsBaseAppShell::Run()	widget/nsBaseAppShell.cpp:156
6 	xul.dll	nsAppShell::Run()	widget/windows/nsAppShell.cpp:257 

bp-631951c3-79a9-47d1-82c1-45ce52170131 forwarding from Sent

bp-765844e4-a7b8-47ec-88d5-293a12170131 when opening from a sublevel folder of my Templates folder. If there is a signature included in the templated email

Comment 1

[Wayne Mery (:wsmwk)]

can't tell if it happens in TB53 or TB54

Comment 2

[Wayne Mery (:wsmwk)]

> Perhaps fallout from an uplift?

must be one of these https://mzl.la/2ksC3TI - perhaps imap bug 1328814?
applicable also to bug 1335638

Comment 3

[Jorg K (CEST = GMT+2)]

Hmm, nsSyncRunnableHelpers.cpp:146 is this:
  NS_IMETHOD Run() {
    mResult = (mReceiver->*mMethod)(mArg1, mArg2); <===
    mozilla::MonitorAutoLock(mMonitor).Notify();
    return NS_OK;
  }

You've already asked me about this in bug 1332606. Sorry, no, that was at line 118 of the same file which is similar:
  mResult = (mReceiver->*mMethod)(mArg1);
It's also crashing there in bug 1335638.

Bug 1332606 comment #2 has some hints. I guess it might all have the same cause. Somehow that has slipped down on my to-do list since other fires were burning hotter.

Nothing on your bug list springs to mind, but of course fixing one code path can then run into a problem in some other code path. Sadly I don't think I have any spare cycles to look into it further, maybe Kent has, and surely he could get straight to the point given his comments in bug 1332606 comment #2.

Comment 4

[Wayne Mery (:wsmwk)]

like bug 1335638, 51.0b1 had only a smallish number of crashes [1]. only 10 total

and like bug 1335638, earliest is bp-4e2a7cb2-4f17-4987-80db-1a97e2170113 from 2017-01-13 which predates the release => some of our testers crashed https://www.mozilla.org/en-US/thunderbird/51.0beta/releasenotes/

[1] https://crash-stats.mozilla.com/signature/?signature=%5Bthunk%5D%3Amozilla%3A%3Astorage%3A%3AConnection%3A%3A%60vcall%27%27%7B100%2C%20%7Bflat%7D%7D%27%27%20%7D%27%27&date=%3E%3D2017-01-25T21%3A15%3A00.000Z&date=%3C2017-02-01T21%3A15%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_sort=-date&page=1

Comment 5

[Jorg K (CEST = GMT+2)]

This was caused by bug 1328814 and will be fixed in 45.7.1 by backing out that bug.

Other versions will be fixed differently, see bug 1335638. I'm closing this now since we have four open bugs for the same issue which is well understood.