1335592 - Implement jstests.py --include and --exclude

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

--exclude is handy for skipping large swathes of tests. May be useful if we need to skip eg test262. --include is redundant with the list of tests at the end of the command line, but with the current setup there is a place where it's easy to add options to jstests.py, but hard to append things to the overall command line.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Implement jstests.py --include and --exclude options for including and excluding files or directories

Sorry about the totally random review request.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Steve Fink [:sfink] [:s:] from comment #1)
> Sorry about the totally random review request.

No need to apologize!

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8832273 [details] [diff] [review]
Implement jstests.py --include and --exclude options for including and excluding files or directories

Review of attachment 8832273 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/lib/manifest.py
@@ +367,5 @@
>  
>      return True
>  
>  
> +def _split_files_and_dirs(location, paths):

A doc comment here would be nice.

@@ +376,5 @@
> +            dirs.add(path[0:-1])
> +        elif os.path.isdir(os.path.join(location, path)):
> +            dirs.add(path)
> +        else:
> +            files.add(path)

Maybe worth checking whether or not the path exists?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ae32e151ec0
Implement jstests.py --include and --exclude options for including and excluding files or directories, r=fitzgen

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/adc12dd054ca
bustage followup - missing colon

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ae32e151ec0
https://hg.mozilla.org/mozilla-central/rev/adc12dd054ca