Closed Bug 1335592 Opened 5 years ago Closed 5 years ago

Implement jstests.py --include and --exclude

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: sfink, Assigned: sfink)

Details

Attachments

(1 file)

--exclude is handy for skipping large swathes of tests. May be useful if we need to skip eg test262. --include is redundant with the list of tests at the end of the command line, but with the current setup there is a place where it's easy to add options to jstests.py, but hard to append things to the overall command line.
Sorry about the totally random review request.
Attachment #8832273 - Flags: review?(nfitzgerald)
(In reply to Steve Fink [:sfink] [:s:] from comment #1)
> Sorry about the totally random review request.

No need to apologize!
Comment on attachment 8832273 [details] [diff] [review]
Implement jstests.py --include and --exclude options for including and excluding files or directories

Review of attachment 8832273 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/lib/manifest.py
@@ +367,5 @@
>  
>      return True
>  
>  
> +def _split_files_and_dirs(location, paths):

A doc comment here would be nice.

@@ +376,5 @@
> +            dirs.add(path[0:-1])
> +        elif os.path.isdir(os.path.join(location, path)):
> +            dirs.add(path)
> +        else:
> +            files.add(path)

Maybe worth checking whether or not the path exists?
Attachment #8832273 - Flags: review?(nfitzgerald) → review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ae32e151ec0
Implement jstests.py --include and --exclude options for including and excluding files or directories, r=fitzgen
https://hg.mozilla.org/mozilla-central/rev/3ae32e151ec0
https://hg.mozilla.org/mozilla-central/rev/adc12dd054ca
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.