133561 - channel links fail to specify port number

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Chris P. Ross]

When a channel is found by the munger, and the channel link installed, the
installed link fails to specify the port (which should be specified if it is not
6667).  This is very similar to, but in a different place, bug #132610.

Comment 1

[Chris P. Ross]

Attachment: Fix modeled after rginda's fix for bug 132610

This is a fix modelled after rgrinda's patch to fix bug #132610.  Works to fix
the same sort of problem, but in munged channel links in the chat text, rather
than in the URL at the top of the chat window.	Should any of the things (in
either patch) continue to be in escape() clauses that currently aren't?  I'm
not sure why rgrinda didn't put host in escape() clauses.

Comment 2

[Robert Ginda]

My handle is rginda, not rgrinda.  Note that there is only one r.

This patch should use eventData.network.getURL(), instead of cut-and-pasting the
other patch.

I didn't escape the host because I assumed any legit host doesn't need to be
escaped, am I wrong?  Networks are escaped because they don' have the same
character restrictions as host names.

Comment 3

[Chris P. Ross]

Doh!  Sorry about that.  More care taken in thinking/typing of handle names now...

Comment 4

[Chris P. Ross]

Attachment: Way cleaner patch per rginda's suggestion

Oh yeah, that's way cleaner.  Sorry I didn't think to do that in the first
place.	Thanks...

Comment 5

[Chris P. Ross]

Hey.  Can someone review/approve and get this checked in?  Or is the tree
frozen now anyway, so that it can't be checked in anywhere?

Comment 6

[Robert Ginda]

Comment on attachment 76253 [details] [diff] [review]
Way cleaner patch per rginda's suggestion

r=rginda

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 76253 [details] [diff] [review]
Way cleaner patch per rginda's suggestion

a=asa (on behalf of drivers) for checkin to 1.3beta

Comment 8

[Robert Ginda]

checked in