Closed
Bug 1335645
Opened 7 years ago
Closed 6 years ago
Fix some of the JS errors in netwerk/test/unit/
Categories
(Core :: Networking, defect, P3)
Core
Networking
Tracking
()
RESOLVED
FIXED
People
(Reporter: valentin, Assigned: valentin, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [necko-backlog])
Attachments
(7 files)
2.58 KB,
patch
|
CuveeHsu
:
review+
|
Details | Diff | Splinter Review |
4.77 KB,
patch
|
bagder
:
review+
|
Details | Diff | Splinter Review |
59 bytes,
text/x-review-board-request
|
CuveeHsu
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
CuveeHsu
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
CuveeHsu
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
CuveeHsu
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
CuveeHsu
:
review+
|
Details |
Several tests have JS errors, and should be fixed.
Assignee | ||
Comment 1•7 years ago
|
||
MozReview-Commit-ID: 2QOdvACvW8z
Attachment #8832319 -
Flags: review?(juhsu)
Updated•7 years ago
|
Attachment #8832319 -
Flags: review?(juhsu) → review+
Assignee | ||
Comment 2•7 years ago
|
||
I created https://public.etherpad-mozilla.org/p/netwerk-unit-test-jserrors to track fixing all the errors. There's a lot of them.
Assignee | ||
Comment 3•7 years ago
|
||
Fixes: line 721: ReferenceError: assignment to undeclared variable uriStrFilterList - declared variable in global scope line 617: ReferenceError: reference to undefined property "spec" - changed onProxyAvailable expectation to be called with a channel instead of URI - now dumping channel.URI.spec - Enabled strict mode. MozReview-Commit-ID: AeC4CtCpDZF
Attachment #8832426 -
Flags: review?(daniel)
Comment 5•7 years ago
|
||
FWIW, I have tested in my local Ubuntu. test_immutable/test_http2/test_altsvc would fail without specifying MOZ_NODE_PATH They deserve good log output for developers. test_unix_domain.js fails with the same reason in Comment 2. test_bug455311.js fails, which is not addressed in Comment 2.
Comment 6•7 years ago
|
||
> test_immutable/test_http2/test_altsvc would fail without specifying > MOZ_NODE_PATH > They deserve good log output for developers. > It's bug 1336776
Updated•7 years ago
|
Attachment #8832426 -
Flags: review?(daniel) → review+
Assignee | ||
Comment 7•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/16da7daff8bfde13f79ec81139e10db3089b7deb Bug 1335645 - part 1 - Fix JS errors in test_reopen.js and test_file_partial_inputstream.js r=junior https://hg.mozilla.org/integration/mozilla-inbound/rev/8c74928ee50cdba904e10ae4fa3737a9039228f7 Bug 1335645 - part 2 - Fix JS errors in test_protocolproxyservice.js r=bagder
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/16da7daff8bf https://hg.mozilla.org/mozilla-central/rev/8c74928ee50c
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 14•7 years ago
|
||
mozreview-review |
Comment on attachment 8841652 [details] Bug 1335645 - Part 3 - Stop server at the end of the test https://reviewboard.mozilla.org/r/115804/#review117674
Attachment #8841652 -
Flags: review?(juhsu) → review+
Comment 15•7 years ago
|
||
mozreview-review |
Comment on attachment 8841653 [details] Bug 1335645 - Part 4 - Fix warning for undeclared variable https://reviewboard.mozilla.org/r/115806/#review117676
Attachment #8841653 -
Flags: review?(juhsu) → review+
Comment 16•7 years ago
|
||
mozreview-review |
Comment on attachment 8841654 [details] Bug 1335645 - Part 5 - Fix warning when test.relativeURI is undefined https://reviewboard.mozilla.org/r/115808/#review117680
Attachment #8841654 -
Flags: review?(juhsu) → review+
Comment 17•7 years ago
|
||
mozreview-review |
Comment on attachment 8841656 [details] Bug 1335645 - Part 7 - Fix warning caused by undeclared variables https://reviewboard.mozilla.org/r/115812/#review117682
Attachment #8841656 -
Flags: review?(juhsu) → review+
Comment 18•7 years ago
|
||
mozreview-review |
Comment on attachment 8841655 [details] Bug 1335645 - Part 6 - Fix warning caused by badly defined unicode characters https://reviewboard.mozilla.org/r/115810/#review117698
Attachment #8841655 -
Flags: review?(juhsu) → review+
Comment 19•7 years ago
|
||
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b4bb760c8767 Part 3 - Stop server at the end of the test r=junior https://hg.mozilla.org/integration/autoland/rev/bf61d746391e Part 4 - Fix warning for undeclared variable r=junior https://hg.mozilla.org/integration/autoland/rev/c43904b6fb09 Part 5 - Fix warning when test.relativeURI is undefined r=junior https://hg.mozilla.org/integration/autoland/rev/b727a8641d40 Part 6 - Fix warning caused by badly defined unicode characters r=junior https://hg.mozilla.org/integration/autoland/rev/e440be3a764b Part 7 - Fix warning caused by undeclared variables r=junior
Comment 20•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b4bb760c8767 https://hg.mozilla.org/mozilla-central/rev/bf61d746391e https://hg.mozilla.org/mozilla-central/rev/c43904b6fb09 https://hg.mozilla.org/mozilla-central/rev/b727a8641d40 https://hg.mozilla.org/mozilla-central/rev/e440be3a764b
Assignee | ||
Updated•7 years ago
|
Assignee: valentin.gosu → nobody
Mentor: valentin.gosu
Keywords: good-first-bug
Whiteboard: [necko-active] → [necko-backlog]
Comment 21•7 years ago
|
||
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: -- → P1
Comment 22•7 years ago
|
||
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: P1 → P3
Comment 23•7 years ago
|
||
Hey can i take charge of bug #1335645? i should be an easy fix.
Assignee | ||
Comment 24•6 years ago
|
||
Closing this as Fixed. Will open separate bugs for follow-up work.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Summary: Fix JS errors in netwerk/test/unit/ → Fix some of the JS errors in netwerk/test/unit/
Updated•6 years ago
|
Keywords: leave-open
Updated•6 years ago
|
status-firefox54:
affected → ---
Updated•6 years ago
|
Assignee: nobody → valentin.gosu
You need to log in
before you can comment on or make changes to this bug.
Description
•