Fix JS errors in netwerk/test/unit/

NEW
Unassigned

Status

()

Core
Networking
P3
normal
10 months ago
2 months ago

People

(Reporter: valentin, Unassigned, Mentored)

Tracking

({good-first-bug, leave-open})

Trunk
good-first-bug, leave-open
Points:
---

Firefox Tracking Flags

(firefox54 affected)

Details

(Whiteboard: [necko-backlog])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(7 attachments)

(Reporter)

Description

10 months ago
Several tests have JS errors, and should be fixed.
(Reporter)

Comment 1

10 months ago
Created attachment 8832319 [details] [diff] [review]
Fix JS errors in test_reopen.js and test_file_partial_inputstream.js

MozReview-Commit-ID: 2QOdvACvW8z
Attachment #8832319 - Flags: review?(juhsu)

Updated

10 months ago
Attachment #8832319 - Flags: review?(juhsu) → review+
(Reporter)

Comment 2

10 months ago
I created https://public.etherpad-mozilla.org/p/netwerk-unit-test-jserrors to track fixing all the errors. There's a lot of them.
(Reporter)

Comment 3

10 months ago
Created attachment 8832426 [details] [diff] [review]
part2 - Fix JS errors in protocolproxyservice

Fixes:
line 721: ReferenceError: assignment to undeclared variable uriStrFilterList
- declared variable in global scope
line 617: ReferenceError: reference to undefined property "spec"
- changed onProxyAvailable expectation to be called with a channel instead of URI - now dumping channel.URI.spec
- Enabled strict mode.
MozReview-Commit-ID: AeC4CtCpDZF
Attachment #8832426 - Flags: review?(daniel)

Updated

10 months ago
Duplicate of this bug: 1136038

Comment 5

10 months ago
FWIW, I have tested in my local Ubuntu.

test_immutable/test_http2/test_altsvc would fail without specifying MOZ_NODE_PATH
They deserve good log output for developers.

test_unix_domain.js fails with the same reason in Comment 2.
test_bug455311.js fails, which is not addressed in Comment 2.

Comment 6

10 months ago
> test_immutable/test_http2/test_altsvc would fail without specifying
> MOZ_NODE_PATH
> They deserve good log output for developers.
> 
It's bug 1336776

Updated

10 months ago
Attachment #8832426 - Flags: review?(daniel) → review+
(Reporter)

Comment 7

10 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/16da7daff8bfde13f79ec81139e10db3089b7deb
Bug 1335645 - part 1 - Fix JS errors in test_reopen.js and test_file_partial_inputstream.js r=junior

https://hg.mozilla.org/integration/mozilla-inbound/rev/8c74928ee50cdba904e10ae4fa3737a9039228f7
Bug 1335645 - part 2 - Fix JS errors in test_protocolproxyservice.js r=bagder

Comment 8

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/16da7daff8bf
https://hg.mozilla.org/mozilla-central/rev/8c74928ee50c
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 14

9 months ago
mozreview-review
Comment on attachment 8841652 [details]
Bug 1335645 - Part 3 - Stop server at the end of the test

https://reviewboard.mozilla.org/r/115804/#review117674
Attachment #8841652 - Flags: review?(juhsu) → review+

Comment 15

9 months ago
mozreview-review
Comment on attachment 8841653 [details]
Bug 1335645 - Part 4 - Fix warning for undeclared variable

https://reviewboard.mozilla.org/r/115806/#review117676
Attachment #8841653 - Flags: review?(juhsu) → review+

Comment 16

9 months ago
mozreview-review
Comment on attachment 8841654 [details]
Bug 1335645 - Part 5 - Fix warning when test.relativeURI is undefined

https://reviewboard.mozilla.org/r/115808/#review117680
Attachment #8841654 - Flags: review?(juhsu) → review+

Comment 17

9 months ago
mozreview-review
Comment on attachment 8841656 [details]
Bug 1335645 - Part 7 - Fix warning caused by undeclared variables

https://reviewboard.mozilla.org/r/115812/#review117682
Attachment #8841656 - Flags: review?(juhsu) → review+

Comment 18

9 months ago
mozreview-review
Comment on attachment 8841655 [details]
Bug 1335645 - Part 6 - Fix warning caused by badly defined unicode characters

https://reviewboard.mozilla.org/r/115810/#review117698
Attachment #8841655 - Flags: review?(juhsu) → review+

Comment 19

9 months ago
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b4bb760c8767
Part 3 - Stop server at the end of the test r=junior
https://hg.mozilla.org/integration/autoland/rev/bf61d746391e
Part 4 - Fix warning for undeclared variable r=junior
https://hg.mozilla.org/integration/autoland/rev/c43904b6fb09
Part 5 - Fix warning when test.relativeURI is undefined r=junior
https://hg.mozilla.org/integration/autoland/rev/b727a8641d40
Part 6 - Fix warning caused by badly defined unicode characters r=junior
https://hg.mozilla.org/integration/autoland/rev/e440be3a764b
Part 7 - Fix warning caused by undeclared variables r=junior

Comment 20

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b4bb760c8767
https://hg.mozilla.org/mozilla-central/rev/bf61d746391e
https://hg.mozilla.org/mozilla-central/rev/c43904b6fb09
https://hg.mozilla.org/mozilla-central/rev/b727a8641d40
https://hg.mozilla.org/mozilla-central/rev/e440be3a764b
(Reporter)

Updated

7 months ago
Assignee: valentin.gosu → nobody
Mentor: valentin.gosu@gmail.com
Keywords: good-first-bug
Whiteboard: [necko-active] → [necko-backlog]
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: -- → P1
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: P1 → P3

Comment 23

2 months ago
Hey can i take charge of bug #1335645? i should be an easy fix.
You need to log in before you can comment on or make changes to this bug.