133573 - Speed up xptcinvoke on AIX

Status: VERIFIED FIXED

(Core :: XPConnect, defect)

Description

[Philip K. Warren]

By removing the invoke_count_words function, and just using an upper bound on
the number of bytes of stack required (max parameter size * number of
parameters), we can improve the speed of the xptcinvoke assembly greatly.

Comment 1

[Philip K. Warren]

Attachment: Patch to remove invoke_count_words

Patch which removes invoke_count_words from xptcinvoke assembly. We assume that
the maximum stack size we need to create is 8 bytes * numParams.

Comment 2

[Philip K. Warren]

A similar improvement was made for Win32 with Bug 111771.

Comment 3

[David Bradley]

Adding perf keyword. 

I'm not real familiar with PPC assember:
+ slwi r3,r4,3 # number of bytes of stack required

I assume this shifts r4 and stores the value in r3.

If that's correct it looks fine to me, do we have any other PPC assembler people
around that could review?

Comment 4

[Phil Schwartau]

Formally confirming bug -

Comment 5

[Jim Dunn]

r=[e-mail]
I tried this out on my aix machine, looks good.

Comment 6

[John Bandhauer]

Comment on attachment 76252 [details] [diff] [review]
Patch to remove invoke_count_words

sr=jband
(flipped reviewed flag for jdunn too)
These aix/ppc changes certainly won't impact anything else.

Comment 7

[Jim Dunn]

reassigning

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 76252 [details] [diff] [review]
Patch to remove invoke_count_words

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 9

[Jim Dunn]

fix checked in

Comment 10

[Phil Schwartau]

Marking Verified -