Closed
Bug 1335743
Opened 9 years ago
Closed 9 years ago
OnClickData modifies were not added to the schema file
Categories
(WebExtensions :: General, defect, P5)
WebExtensions
General
Tracking
(firefox54 fixed)
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: evilpies, Assigned: zombie)
References
Details
(Whiteboard: triaged)
Attachments
(1 file)
Bug 1302742 added modifiers to the object that is passed to the listeners, but didn't add it to the schema file.
|
Reporter | |
Updated•9 years ago
|
Flags: needinfo?(tomica)
|
Assignee | |
Comment 1•9 years ago
|
||
Thanks. Does anything actually depend on output types in the schema? In other words, is this possible to test, to prevents something like this happening again?
Assignee: nobody → tomica
Status: NEW → ASSIGNED
Flags: needinfo?(tomica)
|
||
Updated•9 years ago
|
Priority: -- → P5
Whiteboard: triaged
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8835652 -
Flags: review?(aswan)
|
||
Comment 3•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8835652 [details]
Bug 1335743 - Add modifiers field to OnClickData schema
https://reviewboard.mozilla.org/r/111332/#review112892
Attachment #8835652 -
Flags: review?(aswan) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/25306fd08439
Add modifiers field to OnClickData schema r=aswan
Keywords: checkin-needed
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
|
||
Updated•7 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•