OnClickData modifies were not added to the schema file

RESOLVED FIXED in Firefox 54

Status

P5
normal
RESOLVED FIXED
2 years ago
3 months ago

People

(Reporter: evilpie, Assigned: zombie)

Tracking

unspecified
mozilla54

Firefox Tracking Flags

(firefox54 fixed)

Details

(Whiteboard: triaged)

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Bug 1302742 added modifiers to the object that is passed to the listeners, but didn't add it to the schema file.
(Reporter)

Updated

2 years ago
Flags: needinfo?(tomica)
(Assignee)

Comment 1

2 years ago
Thanks.  Does anything actually depend on output types in the schema?  In other words, is this possible to test, to prevents something like this happening again?
Assignee: nobody → tomica
Status: NEW → ASSIGNED
Flags: needinfo?(tomica)

Updated

2 years ago
Priority: -- → P5
Whiteboard: triaged
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8835652 - Flags: review?(aswan)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8835652 [details]
Bug 1335743 - Add modifiers field to OnClickData schema

https://reviewboard.mozilla.org/r/111332/#review112892
Attachment #8835652 - Flags: review?(aswan) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 4

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/25306fd08439
Add modifiers field to OnClickData schema r=aswan
Keywords: checkin-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/25306fd08439
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54

Updated

3 months ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.