Closed Bug 1335743 Opened 3 years ago Closed 3 years ago

OnClickData modifies were not added to the schema file

Categories

(WebExtensions :: General, defect, P5)

defect

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: evilpie, Assigned: zombie)

References

Details

(Whiteboard: triaged)

Attachments

(1 file)

Bug 1302742 added modifiers to the object that is passed to the listeners, but didn't add it to the schema file.
Flags: needinfo?(tomica)
Thanks.  Does anything actually depend on output types in the schema?  In other words, is this possible to test, to prevents something like this happening again?
Assignee: nobody → tomica
Status: NEW → ASSIGNED
Flags: needinfo?(tomica)
Priority: -- → P5
Whiteboard: triaged
Attachment #8835652 - Flags: review?(aswan)
Comment on attachment 8835652 [details]
Bug 1335743 - Add modifiers field to OnClickData schema

https://reviewboard.mozilla.org/r/111332/#review112892
Attachment #8835652 - Flags: review?(aswan) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/25306fd08439
Add modifiers field to OnClickData schema r=aswan
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/25306fd08439
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.