1335760 - Migrate dispatch_once uses in Profile to be regular properties and de-singleton the class

Status: RESOLVED FIXED

(Firefox for iOS :: Data Storage, defect)

Description

[Stephan Leroux [:sleroux]]

Swift 3 removes the use of dispatch_once which we were using for initializing our loginsDB handle and key only once app-wide. Moving these properties to use static instead also causes issues because files is an instance property and is not accessible from inside the static block. This only worked before because of the use of dispatch_once.

The solution is to migrate Profile to no longer being a singleton and make the loginsDB/key properties regular properties.

Comment 1

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2368#attch-to-bugzilla

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8832499 [details]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2368#attch-to-bugzilla

Waiting for changes.

Comment 3

[Stephan Leroux [:sleroux]]

Comment on attachment 8832499 [details]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2368#attch-to-bugzilla

Reflagging for review. I think Github is being a bit slow because my new commit isn't showing up yet on the PR.