1335776 - autoland-ui: Implement `resetPropsWithUpdates`-style function

Status: RESOLVED FIXED

(Conduit :: General, defect)

Description

[David Walsh :davidwalsh]

To help manage state better (i.e. not do cleanup constantly), we should add something like a `resetPropsWithUpdates` method which combines default props with any updates needed.

Comment 1

[David Walsh :davidwalsh]

Attachment: autoland-ui: Implement resetStateWithUpdates to cleaner state. Also whitespace cleanup. (Bug 1335776)

Review commit: https://reviewboard.mozilla.org/r/108752/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108752/

Comment 2

[David Walsh :davidwalsh]

Comment on attachment 8832495 [details]
autoland-ui: Implement resetStateWithUpdates to cleaner state.  Also whitespace cleanup. (Bug 1335776)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/108752/diff/1-2/

Comment 3

[David Walsh :davidwalsh]

Comment on attachment 8832495 [details]
autoland-ui: Implement resetStateWithUpdates to cleaner state.  Also whitespace cleanup. (Bug 1335776)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/108752/diff/2-3/

Comment 4

[Israel Madueme [:imadueme]]

Comment on attachment 8832495 [details]
autoland-ui: Implement resetStateWithUpdates to cleaner state.  Also whitespace cleanup. (Bug 1335776)

https://reviewboard.mozilla.org/r/108752/#review109962

::: autoland/ui/src/components/AutolandController.jsx:44
(Diff revision 2)
> +          });
>            return;
>          }
>  
>          response.json().then(data => {
> -          this.setState({ data, error: null });
> +          this.resetPropsWithUpdates({ data });

was wondering why `{data}` was valid instead of `{data: data}`, but, a little testing and googling led me to learn about http://eslint.org/docs/rules/object-shorthand. LGTM!

Comment 5

[Mark Côté [:mcote]]

Comment on attachment 8832495 [details]
autoland-ui: Implement resetStateWithUpdates to cleaner state.  Also whitespace cleanup. (Bug 1335776)

https://reviewboard.mozilla.org/r/108752/#review109988

Rubber stamp for landing.

Comment 6

[David Walsh :davidwalsh]

Comment on attachment 8832495 [details]
autoland-ui: Implement resetStateWithUpdates to cleaner state.  Also whitespace cleanup. (Bug 1335776)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/108752/diff/3-4/

Comment 7

[Israel Madueme [:imadueme]]

Comment on attachment 8832495 [details]
autoland-ui: Implement resetStateWithUpdates to cleaner state.  Also whitespace cleanup. (Bug 1335776)

https://reviewboard.mozilla.org/r/108752/#review110016

Still looks good!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/automation/conduit/rev/046fae9d9d38
autoland-ui: Implement resetStateWithUpdates to cleaner state.  Also whitespace cleanup. r=imadueme,mcote