Closed Bug 1335794 Opened 3 years ago Closed 3 years ago

JavaScript Error: "TypeError: mm is null" {file: "resource:///modules/ContentWebRTC.jsm" line: 139}

Categories

(Firefox :: Site Permissions, defect)

53 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 54
Tracking Status
firefox52 --- unaffected
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: florian, Assigned: mchiang)

References

Details

Attachments

(1 file)

This error appears in test logs a lot, eg. when running browser/base/content/test/webrtc/browser_devices_get_user_media_screen.js

Line 139 is:
  mm.sendAsyncMessage("webrtc:StopRecording", request);
from http://searchfox.org/mozilla-central/rev/e95e4ed8b5229a29dacc32c0b90968df5e7a6ff3/browser/modules/ContentWebRTC.jsm#139 / bug 1270572.

I think we should just add a null check like http://searchfox.org/mozilla-central/rev/e95e4ed8b5229a29dacc32c0b90968df5e7a6ff3/browser/modules/ContentWebRTC.jsm#356 does, as the message manager may no longer exist if the user has reloaded the tab.
Assignee: nobody → mchiang
Comment on attachment 8832732 [details]
Bug 1335794 - Fix JavaScript Error (TypeError: mm is null) by adding a null checking;

https://reviewboard.mozilla.org/r/108938/#review110278

Thanks!
Attachment #8832732 - Flags: review?(florian) → review+
Whiteboard: [checkin-needed-aurora]
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/42cd21f10830
Fix JavaScript Error (TypeError: mm is null) by adding a null checking; r=florian
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/42cd21f10830
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.