1335840 - Create Third Party Alert Hook

Status: RESOLVED FIXED

(Taskcluster :: Operations and Service Requests, task)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

I'd like to turn https://tools.taskcluster.net/hooks/#garbage/tjrtest2 into a long-lived task.  It should run sometime during not-work hours on weekday nights.

"metadata": {
    "name": "Third Party Library Alert Service",
    "description": "This checks the in-tree version of libraries and fails (firing an alert) when a library is out of date. The script alerts one person right now, who will open a bug about the revision bump, and then mark an "ignore this out of date revision flag" in the code. In the future, all improvements are possible. (Open a Github issue!) Similarly, right now the script is maintained by a few people but hopefully soon updating it will be a standard practice when third party libraries are copied in-tree.",
    "owner": "[e-mail]",
    "source": "https://github.com/mozilla-services/third-party-library-alert"
  },

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

I'd like to create this hook under the `project-releng` hook group, which would sort of indicate that it's a releng-owned service.  I think that this will develop into an in-tree crontask, but for now it's early days.

My thinking is to use the gecko-t-linux-large workerType for this.

I'll go ahead and get started, but needinfo coop just to check I'm not doing anything crazy here.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

https://tools.taskcluster.net/hooks/#project-releng/misc-third-party-library-alert-service

(with corresponding role)

Comment 3

[Chris Cooper [:coop] (he/him)]

Yes, releng should own this.(In reply to Dustin J. Mitchell [:dustin] from comment #1)
> I'd like to create this hook under the `project-releng` hook group, which
> would sort of indicate that it's a releng-owned service.  I think that this
> will develop into an in-tree crontask, but for now it's early days.
> 
> My thinking is to use the gecko-t-linux-large workerType for this.
> 
> I'll go ahead and get started, but needinfo coop just to check I'm not doing
> anything crazy here.

Yes, releng should own this particular hook.

Comment 4

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Hi Dustin,

The hook is currently failing due to insufficient scopes: https://tools.taskcluster.net/hooks/#project-releng/misc-third-party-library-alert-service

Also, I do not have permission to fire the hook automatically. It would be nice if I could, but if it grants me too broad permission to other stuff, then that is alright.

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

I can fix both of those:)

I added `queue:route:[e-mail].*` to 
  https://tools.taskcluster.net/auth/roles/#hook-id:project-releng%252fmisc-third-party-library-alert-service

I also added `hooks:modify-hook:project-releng/misc-third-party-library-alert-service` and `assume:hook-id:project-releng/misc-third-party-library-alert-service` to 
  https://tools.taskcluster.net/auth/roles/#mozilla-user:[e-mail]
which should give you access to
  https://docs.taskcluster.net/reference/integrations/hooks/api-docs#updateHook
assuming you're logging in as [e-mail] with Okta.

Comment 6

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Everything looks and works great, thanks!